[327] in arla-drinkers
Re: Patch for linux xfs driver
daemon@ATHENA.MIT.EDU (Magnus Ahltorp)
Thu Oct 15 20:05:36 1998
From owner-arla-drinkers@stacken.kth.se Fri Oct 16 00:05:36 1998
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 10457 invoked from network); 16 Oct 1998 00:05:35 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
by bloom-picayune.mit.edu with SMTP; 16 Oct 1998 00:05:35 -0000
Received: (from majordom@localhost)
by sundance.stacken.kth.se (8.8.8/8.8.8) id CAA09446
for arla-drinkers-list; Fri, 16 Oct 1998 02:00:29 +0200 (MET DST)
Received: from yakko.stacken.kth.se (map@yakko.stacken.kth.se [130.237.234.52])
by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id CAA09441;
Fri, 16 Oct 1998 02:00:23 +0200 (MET DST)
Received: (from map@localhost)
by yakko.stacken.kth.se (8.8.8/8.8.7) id BAA18133;
Fri, 16 Oct 1998 01:59:39 +0200 (CEST)
To: trond.myklebust@fys.uio.no
Cc: arla-drinkers@stacken.kth.se
Subject: Re: Patch for linux xfs driver
References: <13862.33525.960105.889521@charged.uio.no>
From: Magnus Ahltorp <map@stacken.kth.se>
Date: 16 Oct 1998 01:59:38 +0200
In-Reply-To: Trond Myklebust's message of Fri, 16 Oct 1998 01:43:00 +0200 (CEST)
Message-ID: <lv13e8pl6l1.fsf@yakko.stacken.kth.se>
Lines: 43
X-Mailer: Gnus v5.3/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk
> I've been having trouble with the odd spurious Oops when running
> ARLA 0.13 on a linux 2.1.125 kernel. I think I've tracked it down to
> various 'IS_ERR' macros 'Oops'ing due to positive error-values being
> returned by ARLA routines.
>
> Would somebody knowledgeable of ARLA internals please check the
> following patch to 'xfs/linux' for correctness?
FYI, this was fixed a week ago. We are making a new release soon.
I have fixed it in another way:
Index: xfs_dev.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/linux/xfs_dev.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- xfs_dev.c 1998/10/02 04:40:30 1.25
+++ xfs_dev.c 1998/10/09 04:27:50 1.26
@@ -537,7 +537,10 @@
}
else {
memmove(t->message, message, size);
- t->error_or_size = -message->error;
+ if (message->error < 0)
+ t->error_or_size = -EPROTO;
+ else
+ t->error_or_size = -message->error;
}
if (t->wait_queue)
wake_up(&t->wait_queue);
@@ -565,7 +568,10 @@
}
else {
memmove(t->message, message, size);
- t->error_or_size = -message->error;
+ if (message->error < 0)
+ t->error_or_size = -EPROTO;
+ else
+ t->error_or_size = -message->error;
}
if (t->wait_queue)
wake_up(&t->wait_queue);
