[251] in arla-drinkers

home help back first fref pref prev next nref lref last post

Re: vfs changes in 3.0-CURRENT (arla-0.1)

daemon@ATHENA.MIT.EDU (Assar Westerlund)
Sun Sep 13 21:16:23 1998

From owner-arla-drinkers@stacken.kth.se Mon Sep 14 01:16:22 1998
Return-Path: <owner-arla-drinkers@stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 28692 invoked from network); 14 Sep 1998 01:16:21 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
  by bloom-picayune.mit.edu with SMTP; 14 Sep 1998 01:16:21 -0000
Received: (from majordom@localhost)
	by sundance.stacken.kth.se (8.8.8/8.8.8) id DAA15627
	for arla-drinkers-list; Mon, 14 Sep 1998 03:11:38 +0200 (MET DST)
Received: from assaris.pdc.kth.se (assaris.pdc.kth.se [193.10.159.45])
	by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id DAA15623
	for <arla-drinkers@stacken.kth.se>; Mon, 14 Sep 1998 03:11:35 +0200 (MET DST)
Received: (from assar@localhost) by assaris.pdc.kth.se (8.8.5/8.7.3) id DAA07976; Mon, 14 Sep 1998 03:13:53 +0200 (MET DST)
To: David Quattlebaum <sasdrq@unx.sas.com>
Cc: freebsd-current@freebsd.org (current), arla-drinkers@stacken.kth.se
Subject: Re: vfs changes in 3.0-CURRENT (arla-0.1)
References: <199809112100.RAA06836@sports.pc.sas.com>
Mime-Version: 1.0 (generated by tm-edit 7.68)
Content-Type: multipart/mixed;
 boundary="Multipart_Mon_Sep_14_03:13:52_1998-1"
Content-Transfer-Encoding: 7bit
From: Assar Westerlund <assar@sics.se>
Date: 14 Sep 1998 03:13:52 +0200
In-Reply-To: David Quattlebaum's message of "Fri, 11 Sep 1998 17:00:53 -0400 (EDT)"
Message-ID: <5lk937jy27.fsf@assaris.pdc.kth.se>
Lines: 80
X-Mailer: Gnus v5.5/Emacs 19.34
Sender: owner-arla-drinkers@stacken.kth.se
Precedence: bulk

--Multipart_Mon_Sep_14_03:13:52_1998-1
Content-Type: text/plain; charset=US-ASCII

David Quattlebaum <sasdrq@unx.sas.com> writes:
> Good Afternoon,

Hi

> I'm looking at modifying arla-0.1 (free afs implementation)
> to work with FreeBSD 3.0-CURRENT. I'm running into problems with
> the changes to kernel vfs code.

As Magnus already said, 0.1 is really old and you should base your
hacking on something more recent like 0.9.

>    vfs_busy() has 4 arguments now.

That should work with 0.9 which checks the number of arguments of
vfs_busy()

>    vfs_unbusy() has more args too.

same as above

>    NCHNAMLEN no longer used.

The following (untested) patch should fix that problem.

>    getnewfsid() no longer exists. (do I need to write my own
>                                    xfs_getnewfsid())?

0.9 should use vfs_getnewfsid() instead when there's such a function.

> 
> Has anyone tried to make arla-0.1 work with 3.0-CURRENT with
> any success?

According to what I've heard it has worked on some vintage of 3.0, but
that might have been some time ago.

/assar

--Multipart_Mon_Sep_14_03:13:52_1998-1
Content-Type: text/plain; charset=US-ASCII

Index: xfs/bsd/xfs_vnodeops-common.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/bsd/xfs_vnodeops-common.c,v
retrieving revision 1.5
diff -u -w -u -w -r1.5 xfs_vnodeops-common.c
--- xfs_vnodeops-common.c	1998/07/23 04:18:45	1.5
+++ xfs_vnodeops-common.c	1998/09/14 01:09:39
@@ -439,7 +439,7 @@
 
 	    if (error == 0)
 		error = ((struct xfs_message_wakeup *) & msg)->error;
-	    if(error == ENOENT && cnp->cn_namelen <= NCHNAMLEN) {
+	    if(error == ENOENT) {
 		XFSDEB(XDEBVNOPS, ("xfs_lookup: neg cache %p (%s, %ld)\n",
 				   dvp,
 				   cnp->cn_nameptr, cnp->cn_namelen));
Index: xfs/bsd/xfs_node-bsd.c
===================================================================
RCS file: /usr/local/cvsroot/arla/xfs/bsd/xfs_node-bsd.c,v
retrieving revision 1.5
diff -u -w -u -w -r1.5 xfs_node-bsd.c
--- xfs_node-bsd.c	1998/07/23 06:28:38	1.5
+++ xfs_node-bsd.c	1998/09/14 01:09:57
@@ -401,7 +401,9 @@
 		      "dvp = %p, vp = %p, cnp = (%s, %ld, %lu)\n",
 		      dvp, vp, cnp->cn_nameptr, cnp->cn_namelen, cnp->cn_hash));
 
+#ifdef NCHNAMLEN
     if (cnp->cn_namelen <= NCHNAMLEN)
+#endif
 	cache_enter(dvp, vp, cnp);
 
     if (vp != NULL)

--Multipart_Mon_Sep_14_03:13:52_1998-1--

home help back first fref pref prev next nref lref last post