[14] in arla-drinkers

home help back first fref pref prev next nref lref last post

with_krbafs broken

daemon@ATHENA.MIT.EDU (Mark Eichin)
Fri Jun 19 12:08:17 1998

From arla-drinkers-request@sundance.stacken.kth.se Fri Jun 19 16:08:16 1998
Return-Path: <arla-drinkers-request@sundance.stacken.kth.se>
Delivered-To: arla-drinkers-mtg@bloom-picayune.mit.edu
Received: (qmail 22214 invoked from network); 19 Jun 1998 16:08:15 -0000
Received: from unknown (HELO sundance.stacken.kth.se) (130.237.234.41)
  by bloom-picayune.mit.edu with SMTP; 19 Jun 1998 16:08:15 -0000
Received: from swat.thok.org (mail@swat.thok.org [199.103.225.10])
	by sundance.stacken.kth.se (8.8.8/8.8.8) with ESMTP id SAA14431
	for <arla-drinkers@stacken.kth.se>; Fri, 19 Jun 1998 18:01:46 +0200 (MET DST)
Received: from eichin by swat.thok.org with local (Exim 1.92 #1 (Debian))
	id 0yn3ba-0004cN-00; Fri, 19 Jun 1998 12:01:35 -0400
From: Mark Eichin <eichin@kitten.gen.ma.us>
To: arla-drinkers@stacken.kth.se
Subject: with_krbafs broken
Message-Id: <E0yn3ba-0004cN-00@swat.thok.org>
Date: Fri, 19 Jun 1998 12:01:35 -0400

arla 0.7.2, configure.in:

AC_ARG_WITH(krbafs,
[  --with-krbafs=dir       use libkrbafs (from cmu, extracted from kth-krb) in dir],
[if test "X$with_krbafs" = "X"; then
  AC_MSG_ERROR([You have to give the path to krbafs lib])
else
  with_krbafs=yes
fi]
)

Note that with_krbafs is *where the path is stored* - so that when you
set it to "yes" you obliterate the argument.  This has the amusing but
regrettable side effect of introducing -Lyes into the compile command
lines... 

Untested but likely patch follows - just diverts the string to another
variable.  It might be cleaner to just ditch the else clause
altogether and change the later test to a case...
				_Mark_ <eichin@kitten.gen.ma.us>
				The Herd Of Kittens

*** configure.in	1998/06/19 15:58:40	1.1
--- configure.in	1998/06/19 15:59:07
***************
*** 180,185 ****
--- 180,186 ----
  [if test "X$with_krbafs" = "X"; then
    AC_MSG_ERROR([You have to give the path to krbafs lib])
  else
+   krb_afs_path=${with_krbafs}
    with_krbafs=yes
  fi]
  )
***************
*** 284,290 ****
    RXKAD="rxkad"
    RXKAD_LIBS="-L../rxkad -lrxkad $KRB_LIB_FLAGS"
    if test "X$with_krbafs" = "Xyes"; then
!     KAFS_LIBS="-L${with_krbafs} -lkafs"
    else
      KAFS_LIBS="-L${KRB_LIB_DIR} -lkafs"
    fi
--- 285,291 ----
    RXKAD="rxkad"
    RXKAD_LIBS="-L../rxkad -lrxkad $KRB_LIB_FLAGS"
    if test "X$with_krbafs" = "Xyes"; then
!     KAFS_LIBS="-L${krbafs_path} -lkafs"
    else
      KAFS_LIBS="-L${KRB_LIB_DIR} -lkafs"
    fi

home help back first fref pref prev next nref lref last post