[821] in SIPB_Linux_Development

home help back first fref pref prev next nref lref last post

[Linus.Torvalds@cs.Helsinki.FI: Re: Bug in linux kernel 1.1.65]

daemon@ATHENA.MIT.EDU (nocturne@MIT.EDU)
Thu Nov 24 11:49:37 1994

From: nocturne@MIT.EDU
Date: Thu, 24 Nov 1994 11:49:34 -0500
To: linux-dev-mtg@charon.MIT.EDU


Here's the patch that fixes the bug I found in 1.1.65.... Whee.

Date: Thu, 24 Nov 1994 10:40:09 +0200
From: Linus Torvalds <Linus.Torvalds@cs.Helsinki.FI>
In-Reply-To: nocturne@MIT.EDU's message as of Nov 24,  1:48
X-Mailer: Mail User's Shell (7.2.0 10/31/90)
To: nocturne@MIT.EDU
Subject: Re: Bug in linux kernel 1.1.65

nocturne@MIT.EDU: "Bug in linux kernel 1.1.65" (Nov 24,  1:48):
> 
> Hello. I have been observing a consistent bug in my network interactions,
> which seems to be caused by network changes between the 1.1.64 linux kernel
> and the 1.1.65 linux kernel.

Ok, Alan already had found it: patch enclosed (byte-order problem as
suspected):

----------
--- devinet.c~	Wed Nov 23 19:09:10 1994
+++ devinet.c	Wed Nov 23 19:09:10 1994
@@ -151,7 +151,7 @@
 				return IS_BROADCAST;
 		}
 	}
-	if(IN_MULTICAST(addr))
+	if(IN_MULTICAST(ntohl(addr)))
 		return IS_MULTICAST;
 	return 0;		/* no match at all */
 }
----------

That should fix it,

		Linus

home help back first fref pref prev next nref lref last post