[3053] in SIPB_Linux_Development
Re: Post install script
daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Fri Oct 6 19:17:59 2000
Message-Id: <200010062317.TAA10141@speaker-for-the-dead.mit.edu>
From: Jonathon Weiss <jweiss@MIT.EDU>
To: Derek Atkins <warlord@MIT.EDU>
cc: Jonathon Weiss <jweiss@MIT.EDU>, Alex Coventry <alex_c@MIT.EDU>,
Linux-Dev <linux-dev@MIT.EDU>
In-reply-to: Your message of "06 Oct 2000 16:49:52 EDT."
<sjmpuldy9sf.fsf@rcn.ihtfp.org>
Date: Fri, 06 Oct 2000 19:17:52 -0400
> Jonathon Weiss <jweiss@MIT.EDU> writes:
>
> > alex_c>$ROOT/bin/sed -e "s/localhost.localdomain/$HOSTNAME/" \
> > alex_c> -e "s/PUBLIC=false/PUBLIC=false/" \
> > alex_c> -e "s/ADDR=/ADDR=$ADDR/" \
> > alex_c> -e "s/HOST=/HOST=$HOSTNAME/" \
> > alex_c> -e "s/MACHINE=i[3456]86/MACHINE=$MACHINE/" \
> > alex_c> $ROOT/etc/athena/rc.conf > /tmp/rc.conf
> >
> > Having the 1st and 4th lines written the way they are seems dangerous.
> > Perhaps the 3rd and 4th linse should onlt do the substitution if the
> > variables are empty.
>
> I'm not convinced that the 1st line is dangerous. Why do you think
> so? I agree with your assessment of the 3rd and 4th lines. I would
> recommend something like:
Sorry, I was think that 1st was a problem in combination wihthte 3rd,
but really it's the 3rd line that needs fixing, the first should be
fine.
Jonathon
