[2726] in SIPB_Linux_Development
Re: Bug: athena-ttylogin
daemon@ATHENA.MIT.EDU (Salvatore Valente)
Mon Apr 5 12:25:33 1999
Date: Mon, 5 Apr 1999 12:23:23 -0400
To: Derek Atkins <warlord@MIT.EDU>
Cc: linux-dev@MIT.EDU
In-Reply-To: "[8282] in linux-help archive"
From: Salvatore Valente <svalente@MIT.EDU>
Derek wrote:
%triggerin -- util-linux
if [ ! -f /bin/login.orig -a ! -L /bin/login ]; then
...
Clearly this will only run if there isn't a /bin/login.orig.
Exactly. All of the trigger scripts operate under the code of "First,
do no harm." If there's a /bin/login.orig and the script can't
determine what it is, where it came from, if it's important, or if it
can be replaced once it's gone, then the script will not erase it.
Even if that means the script can't do anything.
In this case, I assumed that the existance of a /bin/login.orig file
meant that the sysadmin had manually and intentionally done something
weird with his login system. I wanted to make sure that the
athena-ttylogin package wouldn't erase any local modifications.
I didn't realize that the existance of a /bin/login.orig file could
simply mean that the sysadmin updated util-linux.
This should probably be changed to be:
%triggerin -- util-linux
if [ ! -L /bin/login ]; then
...
Can someone on linux-dev please audit my suggested change?
I still don't like the idea of erasing rather than renaming files, but
I can't think of a better solution, so it looks fine.
Sal.
