[5281] in testers
Mozilla wrapper script gdialog lossage
daemon@ATHENA.MIT.EDU (Greg Hudson)
Fri Apr 11 17:40:06 2003
Date: Fri, 11 Apr 2003 17:40:03 -0400
Message-Id: <200304112140.h3BLe3ub015014@error-messages.mit.edu>
From: Greg Hudson <ghudson@MIT.EDU>
To: testers@MIT.EDU
The GNOME 2 gdialog has changed in a few ways which break our mozilla
startup script. A radio button dialog must specify "on" or "off" as
status values ("--" is not okay), and there is no more text wrapping
(see <http://bugzilla.gnome.org/show_bug.cgi?id=74466>, which I have
reopened).
Also, the dialog looks positively horrible. (As Buffy once said,
"Okay, raise your hand if ew.") There's no spacing around the text,
so it runs right up to the edge (though you can add your own spaces
and it will respect them, which is arguably kind of dumb). The radio
button options contain the option name, so they look like "Exit quit,
leaving lock file in place". And the options live in a box which is a
few pixels too short, no matter what size arguments we pass on the
command line.
I recommend the following:
* Since gdialog won't wrap text for us, the text box will always
look bad as long as we are conditonally inserting long phrases
like ", which still seems to be running". I recommend blowing
away the lock file without asking the user if it's a local process
which isn't running any more, and then we have no need to insert
text.
* Why are we using radio buttons when we have mutually exclusive
options? We should be using a menu. And maybe menus don't look
as terrible.
* With the broken text re-wrapping gone, there is no longer any need
to use the non-breaking space hack, and it doesn't work any more.
This is as far as I got on making the dialog look halfway reasonable.
Note the trailing space after "place,".
dialog_text="
Your Mozilla profile directory contains a lock file, but no existing
Mozilla window can be detected. The lock is owned by process
$lock_pid on ${lock_host:-$lock_ip}$pid_text. If you know for certain that
this lock file is stale, i.e. that you are not running Mozilla on any
machine, you may choose to delete the lock file and continue.
Otherwise, you may choose to continue with the lock file in place,
in which case Mozilla will display its Profile Manager, allowing
you to select or create a different profile (Mozilla will not permit
you to use a profile which it believes to be in use). Or, you can
simply exit, leaving the lock file in place.
"
gdialog --title "Mozilla profile locked" --radiolist "$dialog_text" \
60 60 3 \
Exit "quit, leaving lock file in place" on \
Continue "invoke Mozilla's Profile Manager" off \
Delete "delete lock file and proceed" off 2>&1
