[5132] in testers

home help back first fref pref prev next nref lref last post

Re: eolcr breaks under emacs 21

daemon@ATHENA.MIT.EDU (Arun A Tharuvai)
Tue Apr 23 12:31:38 2002

Date: Tue, 23 Apr 2002 12:31:34 -0400
From: Arun A Tharuvai <aatharuv@MIT.EDU>
To: chad <y@MIT.EDU>, testers@MIT.EDU, eolcdev@MIT.EDU
Cc: aatharuv@MIT.EDU
Message-ID: <20020423163134.GC1675@dorm.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200204221638.g3MGccZ03918@egon.jenwa.org>

I debugged the problem a bit more, and it appears to be caused by a
change in behavior in the concat function between emacs20 and emacs21.

olcr-uid returns the number 8106, and not a string "8106". In emacs
20, the following code 

(concat "/tmp/olcr-replay-" "paco" "0" "." 8106)
returns
"/tmp/olcr-replay-brandonw0.8106"

whereas the same code returns the following error in emacs 21:

Debugger entered--Lisp error: (wrong-type-argument sequencep 8106)
  concat("/tmp/olcr-replay-" "brandonw" "0" "." 8106)
  eval((concat "/tmp/olcr-replay-" "brandonw" "0" "." 8106))
  eval-last-sexp-1(nil)
  eval-last-sexp(nil)
  call-interactively(eval-last-sexp)


Quoting it seems to work in both emacs20 and emacs21. 

Changing  the following in definitions.el

(defvar olcr-uid (user-uid)
  "The UID of the consultant running OLCR.")

to

(defvar olcr-uid (concat (user-uid))
  "The UID of the consultant running OLCR.")

_should_ work, and I'm currently testing this out (making changes to a
few paths in the elisp), to make sure that this actually works.


Arun

On Mon, Apr 22, 2002 at 12:38:37PM -0400, chad wrote:
> 
> M-x toggle-debug-on-error RET and send the stack trace.  (in the emacs
> debugger window, `c' continues, `d' steps, and `q' quits)
> 
> 

eolcdev: Here was my initial email which should have been sent to you.

[5131] daemon@ATHENA.MIT.EDU (Arun A Tharuvai)  testers  04/22/02 12:34 (39 lines)
Subject: eolcr breaks under emacs 21
Date: Mon, 22 Apr 2002 12:34:27 -0400
From: Arun A Tharuvai <aatharuv@MIT.EDU>
To: testers@MIT.EDU
Cc: aatharuv@MIT.EDU
Message-ID: <20020422163427.GA1675@dorm.mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Emacs olcr doesn't work under emacs 21. More specifically, olcr-list
worksm but whenever I try to replay a conversation, I get the error:

Wrong type argument: sequencep, 8106

(8106 is my Athena uid)

Here's some related spew from my *Messages* buffer.

olcr-execute: Wrong type argument: sequencep, 8106
Finished updating user list.  Type ? to get help on using OLCR.
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106
Reading user conversation...
olcr-make-replay-filename: Wrong type argument: sequencep, 8106

Arun

-- 

home help back first fref pref prev next nref lref last post