[3422] in testers

home help back first fref pref prev next nref lref last post

Bugs in attach -Padd

daemon@ATHENA.MIT.EDU (Greg Hudson)
Sun Apr 12 17:38:59 1998

Date: Sun, 12 Apr 1998 17:38:52 -0400
From: Greg Hudson <ghudson@MIT.EDU>
To: testers@MIT.EDU
Cc: cfields@MIT.EDU

Aaron Ucko recently reported that "attach -Padd -e -b" gives output
appropriate for a csh-based shell.  And in fact, the conditional near
the end of add.c doesn't take into account Bourne shell output in the
-e case.  That may have been intentional, but I think some Bourne
shell users would like to be able to use athena_path.  (I don't know
*why*, but at least Aaron seems to want to.)  At any rate, the
documentation doesn't mention this gap at all.

But, more importantly, while exploring this problem I got "attach
-Padd" to seg fault, by running

	attach -Padd -e -b netbsd

as root on a Sun.  It appears that sl_grab_string(path, ' ') was
returning NULL and this caused the corresponding printf to dump core.
The whole conditional there needs more error-checking.

home help back first fref pref prev next nref lref last post