[1270] in testers

home help back first fref pref prev next nref lref last post

cleanup has a bufsiz problem

daemon@ATHENA.MIT.EDU (daemon@ATHENA.MIT.EDU)
Fri Nov 30 14:16:37 1990

From: epeisach@ATHENA.MIT.EDU
Date: Fri, 30 Nov 90 14:16:18 -0500
To: mar@ATHENA.MIT.EDU
Cc: testers@ATHENA.MIT.EDU



After noticing entries in soup's console to the affect of 
cleanup: Corrupt group entry "hy,tom,tompalka."

I looked at the sources.

Around line 423:

    /* loop over each line in the group file */
    while (fgets(buf, BUFSIZ, old)) {
	/* take out tailing \n */
	n = strlen(buf);
	if (n) buf[n - 1] = 0;
	if ((p = index(buf, ':')) == 0 ||
	    (p = index(p+1, ':')) == 0 ||
	    (p = index(p+1, ':')) == 0) {
	    fprintf(stderr, "cleanup: Corrupt group entry \"%s\".\n", buf);
	    continue;
	}


What's happening is that Jay keeps his machine privatized and therefore
keeps an up to date group list of all people in a_staff. This is greater
that 1024 characters and cleanup continues reading in the middle of the
line.

	Ezra

home help back first fref pref prev next nref lref last post