[28447] in Source-Commits
Re: scripts commit: Switch to qemu from vmware; enhance tests
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Thu Sep 25 17:55:16 2014
Date: Thu, 25 Sep 2014 17:54:55 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: "source-commits@MIT.EDU" <source-commits@MIT.EDU>
In-Reply-To: <65C356C0-14CE-46AF-8C93-FFE3C8B6A787@mit.edu>
Message-ID: <alpine.GSO.1.10.1409251753500.21571@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Thu, 25 Sep 2014, Jonathan D Reed wrote:
>
> On Sep 25, 2014, at 4:53 PM, Benjamin Kaduk <kaduk@MIT.EDU> wrote:
>
> >> +[ -n "$SUITE" ] || die "SUITE unspecified"
> >> +[ -f "$ISOLINUXBIN" ] || die "$ISOLINUXBIN missing"
> >
> > It may be better to not have the dollar sign there?
>
> Where? In the error message?
In the error message, yes. The particular case that came to mind was if
the variable was empty, so that the logged message would just be "
missing", which is not especially helpful.
-Ben
