[28307] in Source-Commits
Re: dconf-config commit: Ship a flag file; switch to Makefile
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sun Jul 6 11:14:48 2014
Date: Sun, 6 Jul 2014 11:14:38 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201406181338.s5IDcaQV007063@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1407061113090.17412@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
More from the paranoid-quoting department.
On Wed, 18 Jun 2014, Jonathan D Reed wrote:
> https://github.com/mit-athena/dconf-config/commit/9549cd39ecd81378c753ca9faf9793240f7d78d0
> commit 9549cd39ecd81378c753ca9faf9793240f7d78d0
> Author: Jonathan Reed <jdreed@mit.edu>
> Date: Wed Jun 18 07:37:08 2014 -0400
>
> Ship a flag file; switch to Makefile
>
> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..a3b9706
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,16 @@
> +CODENAME = $(shell lsb_release -sc)
> +
> +.PHONY: clean all install
> +
> +all: athena_user
> +
> +athena_user:
> + @echo "user-db:user_$(CODENAME)" > $@
> + @echo "system-db:athena" >> $@
> +
> +install: athena_user
> + mkdir -p $(DESTDIR)/etc/dconf/profile
> + install -m 0644 athena_user $(DESTDIR)/etc/dconf/profile
Do we generally not expect things to work when DESTDIR contains spaces?
I think make will expand make variables before passing the line off to the
shell.
-Ben
> +
> +clean:
> + rm -f athena_user
