[27579] in Source-Commits
xdsc commit: Clean up comments in get_meeting()
daemon@ATHENA.MIT.EDU (Jonathan D Reed)
Mon Feb 3 15:59:27 2014
Date: Mon, 3 Feb 2014 15:59:20 -0500
From: Jonathan D Reed <jdreed@MIT.EDU>
Message-Id: <201402032059.s13KxKg8010597@drugstore.mit.edu>
To: source-commits@MIT.EDU
https://github.com/mit-athena/xdsc/commit/c5187e09ced77aad730ddea1a02fb67492d221ab
commit c5187e09ced77aad730ddea1a02fb67492d221ab
Author: Jonathan Reed <jdreed@mit.edu>
Date: Tue Dec 31 12:35:51 2013 -0500
Clean up comments in get_meeting()
Explain why we do the check_update() hack, and remove incorrect
comments in docstring about caching connections.
xdsc.py | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/xdsc.py b/xdsc.py
index 525e069..58920f0 100755
--- a/xdsc.py
+++ b/xdsc.py
@@ -77,14 +77,16 @@ class DiscussWrapper:
def get_meeting(self, name):
"""
Load the meeting, cache it, and return it.
- N.B. We can't cache connections (discuss.Client) otherwise
- hilarity ensues.
"""
dslogger.debug('get_meeting %s', name)
location = self.rcfile.lookup(name)
if location not in self.meetingcache:
mtg = discuss.Meeting(self._get_connection(location[0]),
location[1])
+ # The following is a hack. We should just be able to call
+ # load_info(), but it causes a double-free in disserve.
+ # This was fixed in commit 98121288 upstream, but not all
+ # servers have been updated.
try:
mtg.check_update(0)
except discuss.client.DiscussError as e:
