[27187] in Source-Commits

home help back first fref pref prev next nref lref last post

Re: /svn/athena r25996 - in trunk/debathena: config config/chromium-config

daemon@ATHENA.MIT.EDU (Victor Vasiliev)
Wed May 29 07:58:17 2013

Message-ID: <51A5ED46.9010308@mit.edu>
Date: Wed, 29 May 2013 15:57:58 +0400
From: Victor Vasiliev <vasilvv@MIT.EDU>
MIME-Version: 1.0
To: Anders Kaseorg <andersk@MIT.EDU>
CC: source-commits@MIT.EDU
In-Reply-To: <51970EB7.2040909@mit.edu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 05/18/2013 09:16 AM, Anders Kaseorg wrote:
> On 05/17/2013 11:57 PM, Victor Vasiliev wrote:
>> +Build-Depends: debhelper (>= 7.0.50~), config-package-dev (>= 5),
>> chromium-browser | chromium
> 
> You need to be more specific to avoid pulling in the space shooter.  I’d
> write chromium (>= 1) | chromium-browser, in that order so as to prefer
> the new name.

It does not work in that order, because chromium (>= 1) fails to resolve
in Ubuntu as "no installation candidate" and it does not even check
whether chromium-browser is present.

>> +Depends: ${misc:Depends}, chromium-browser | chromium
> 
> That one should be computed at build time with a substvar; we don’t want
> a package compiled against one to be installed with the other.

Fixed in r25998.

>> +    dh_configpackage --transform
>> "/etc/chromium-browser/default.debathena sed
>> -e's/^CHROMIUM_FLAGS=\"/CHROMIUM_FLAGS=\"--auth-server-whitelist=idp.mit.edu
>> /'"
> 
> Transform scripts should exit with nonzero status if they fail to match,
> which is why we usually use perl -0777 -pe 's/foo/bar/ or die'.
> 

Fixed in r25998.

-- Victor.


home help back first fref pref prev next nref lref last post