[27184] in Source-Commits
Re: /svn/athena r25996 - in trunk/debathena: config config/chromium-config
daemon@ATHENA.MIT.EDU (Victor Vasiliev)
Sat May 18 14:57:02 2013
Message-ID: <5197CED6.7020406@mit.edu>
Date: Sat, 18 May 2013 14:56:22 -0400
From: Victor Vasiliev <vasilvv@MIT.EDU>
MIME-Version: 1.0
To: Jonathan Reed <jdreed@MIT.EDU>
CC: Anders Kaseorg <andersk@MIT.EDU>, source-commits@MIT.EDU
In-Reply-To: <D1F85528-43CE-4177-A34D-0B0CA90440CF@mit.edu>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
On 05/18/2013 08:41 AM, Jonathan Reed wrote:
>
> On May 18, 2013, at 1:16 AM, Anders Kaseorg wrote:
>
>> On 05/17/2013 11:57 PM, Victor Vasiliev wrote:
>>> +Build-Depends: debhelper (>= 7.0.50~), config-package-dev (>= 5), chromium-browser | chromium
>>
>> You need to be more specific to avoid pulling in the space shooter. I’d write chromium (>= 1) | chromium-browser, in that order so as to prefer the new name.
>>
>>> +Depends: ${misc:Depends}, chromium-browser | chromium
>>
>> That one should be computed at build time with a substvar; we don’t want a package compiled against one to be installed with the other.
>>
>>> + dh_configpackage --transform "/etc/chromium-browser/default.debathena sed -e's/^CHROMIUM_FLAGS=\"/CHROMIUM_FLAGS=\"--auth-server-whitelist=idp.mit.edu /'"
>>
>> Transform scripts should exit with nonzero status if they fail to match, which is why we usually use perl -0777 -pe 's/foo/bar/ or die'.
>
>
> Also, there are no distros we support that actually have chromium, according to packages.{ubuntu.com,debian.org}. Why not just depend on chromium-browser everywhere, and then move the transform to a .transform file for cleanliness?
>
jessie has it.
-- Victor.
