[27123] in Source-Commits
Re: /svn/athena r25960 - in trunk/debathena/debathena/nautilus-afs:
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Fri May 3 13:19:49 2013
Date: Fri, 3 May 2013 13:19:39 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201305031456.r43EuLKl022985@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1305031318410.9389@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Fri, 3 May 2013, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2013-05-03 10:56:20 -0400 (Fri, 03 May 2013)
> New Revision: 25960
>
> Modified:
> trunk/debathena/debathena/nautilus-afs/afs-property-page.py
> trunk/debathena/debathena/nautilus-afs/debian/changelog
> trunk/debathena/debathena/nautilus-afs/debian/control
> trunk/debathena/debathena/nautilus-afs/debian/copyright
> trunk/debathena/debathena/nautilus-afs/debian/rules
> Log:
> In nautilus-afs:
> * Fix bug which didn't reset "add" dialog after cancel (Trac: #1339)
> * Switch to dh7 from CDBS
> * Bump Standards-Version to 3.9.3 and compat to 7
> * Replace completely wrong copyright file with copyright format 1.0
>
>
> Modified: trunk/debathena/debathena/nautilus-afs/afs-property-page.py
> ===================================================================
> --- trunk/debathena/debathena/nautilus-afs/afs-property-page.py 2013-05-02 15:52:30 UTC (rev 25959)
> +++ trunk/debathena/debathena/nautilus-afs/afs-property-page.py 2013-05-03 14:56:20 UTC (rev 25960)
> @@ -274,6 +274,10 @@
> def _prepareAclDialog(self, editMode=False, entity=None, rights=None, negative=False):
> self.addDlg.set_transient_for(self._getParentWindow())
> self.addDlg.set_title("Change permissions for '%s'" % (entity) if editMode else "Add an entry")
> + # Set entity combo to "specify manually"
> + # This would be easier if GtkBuilder actually set the id-column
> + # property. Fortunately, it's the first entry in the list.
> + self.builder.get_object("entityCombo").set_active_iter(self.builder.get_object("entityCombo").get_model().get_iter_first())
Is it documented that the first entry is the id?
In the absence of such a guarantee, this feels like a fragile hack (not
that I am an experienced GtkBuilder user or anything).
The rest of the stuff looks fine.
-Ben
