[26932] in Source-Commits
Re: /svn/athena r25835 - in trunk/debathena/config/printing-config:
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Wed Mar 6 09:56:16 2013
Date: Wed, 6 Mar 2013 09:56:05 -0500 (EST)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <442273DB-F56E-4F79-8A34-64B3E74FD032@MIT.EDU>
Message-ID: <alpine.GSO.1.10.1303060955400.9389@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Tue, 5 Mar 2013, Jonathan Reed wrote:
>
> On Mar 5, 2013, at 9:08 PM, Benjamin Kaduk wrote:
>
>> On Tue, 5 Mar 2013, Jonathan Reed wrote:
>>
>>> On Mar 5, 2013, at 6:22 PM, Benjamin Kaduk wrote:
>>>
>>>> Appears to function as advertised, ACK.
>>>> I'm not sure I fully agree with commenting out tests for things we no longer use, but on the other hand it's unclear how often the tests get run anyway.
>>>
>>> Are you saying we should delete them instead of commenting out? I'm ok
>>
>> No.
>>
>>> with that. I chose commenting in case we wanted to trivially re-instate them with a different subsystem. But I'm happy to nuke them if you prefer.
>>
>> I didn't see the code implementing is_cups_server (etc.) get removed, so I assume it is still present in the library.
>> My line of thinking it that if we have automated tests for a piece of code, and we still have that piece of code, we should run the tests for that piece of code when we run tests. It doesn't matter that that code has no consumers; it's still code in our library, and we should make sure it doesn't break.
>
> I can delete is_cups_server() or stop exporting it. But what I
> commented out weren't real tests for that function, those were testing
> the order of functions called from simple.simple. So they should be
> commented out because that code is no longer called. In fact, if
> uncommented, the tests fail, because mox is told to expect
> is_cups_server to be called, and it never is.
Ah, okay. That's the piece I was missing.
Thanks,
Ben
