[26930] in Source-Commits
Re: /svn/athena r25835 - in trunk/debathena/config/printing-config:
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Mar 5 21:08:38 2013
Date: Tue, 5 Mar 2013 21:08:24 -0500 (EST)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <58712039-BD84-42D2-8192-6998DEE511F8@MIT.EDU>
Message-ID: <alpine.GSO.1.10.1303052101000.9389@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
On Tue, 5 Mar 2013, Jonathan Reed wrote:
> On Mar 5, 2013, at 6:22 PM, Benjamin Kaduk wrote:
>
>> Appears to function as advertised, ACK.
>> I'm not sure I fully agree with commenting out tests for things we no longer use, but on the other hand it's unclear how often the tests get run anyway.
>
> Are you saying we should delete them instead of commenting out? I'm ok
No.
> with that. I chose commenting in case we wanted to trivially re-instate
> them with a different subsystem. But I'm happy to nuke them if you
> prefer.
I didn't see the code implementing is_cups_server (etc.) get removed, so I
assume it is still present in the library.
My line of thinking it that if we have automated tests for a piece of
code, and we still have that piece of code, we should run the tests for
that piece of code when we run tests. It doesn't matter that that code
has no consumers; it's still code in our library, and we should make sure
it doesn't break.
>>> -def translate_lprng_args_to_cups(args):
>>> - # TODO yell at user if/when we decide that these args are deprecated
>>
>> A bit unfortunate that we did not do something about this TODO, I suppose.
>
> We did in r25463. We just didn't do it at that point in the code. The
> users have been yelled at since April 2012.
Right, I know they've been getting yelled at.
Hmm, I wonder if I noted that this TODO was orphaned when that commit
happened...
>>>
>>> + if os.environ.get('ATHENA_USER'):
>>> system = common.find_queue(queue)[0]
>>> - if argstyle == common.SYSTEM_LPRNG:
>>
>> It looks like argstyle is perhaps unused now, though I did not make a complete check. I guess there's not much value in asserting that it's cups at this point.
>
> We do, but parse_args returns a 3-tuple. I guess I could slice it up
> when returning, but meh?
Meh, indeed.
-Ben
