[26928] in Source-Commits
Re: /svn/athena r25835 - in trunk/debathena/config/printing-config: debathena/printing debian files/usr/share/man/man1
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Tue Mar 5 20:16:01 2013
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1303051811560.9389@multics.mit.edu>
Date: Tue, 5 Mar 2013 20:15:50 -0500
Cc: source-commits@MIT.EDU
Message-Id: <58712039-BD84-42D2-8192-6998DEE511F8@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
On Mar 5, 2013, at 6:22 PM, Benjamin Kaduk wrote:
> Appears to function as advertised, ACK.
> I'm not sure I fully agree with commenting out tests for things we no longer use, but on the other hand it's unclear how often the tests get run anyway.
Are you saying we should delete them instead of commenting out? I'm ok with that. I chose commenting in case we wanted to trivially re-instate them with a different subsystem. But I'm happy to nuke them if you prefer.
>> -def translate_lprng_args_to_cups(args):
>> - # TODO yell at user if/when we decide that these args are deprecated
>
> A bit unfortunate that we did not do something about this TODO, I suppose.
We did in r25463. We just didn't do it at that point in the code. The users have been yelled at since April 2012.
>>
>> + if os.environ.get('ATHENA_USER'):
>> system = common.find_queue(queue)[0]
>> - if argstyle == common.SYSTEM_LPRNG:
>
> It looks like argstyle is perhaps unused now, though I did not make a complete check. I guess there's not much value in asserting that it's cups at this point.
We do, but parse_args returns a 3-tuple. I guess I could slice it up when returning, but meh?
>>
>> - # Result:
>> - os.execvp('mit-lpr', ['lpr', '-Ujdreed', '-Pw20thesis', '-mzephyr%jdreed'])
>> +# # Result:
>> +# os.execvp('mit-lpr', ['lpr', '-Ujdreed', '-Pw20thesis'])
>
> I'm not sure why -mzephyr%jdreed got removed as this was commented.
I'm... not sure why either. Fixed.
-Jon
