[26571] in Source-Commits
Re: /svn/athena r25625 - trunk/athena/lib/firefox-extension/debian
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Tue Jul 10 10:46:11 2012
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1207101029410.18441@multics.mit.edu>
Date: Tue, 10 Jul 2012 10:46:08 -0400
Cc: source-commits@MIT.EDU
Message-Id: <972ECA39-49D5-4F66-8970-11ED7BC50351@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
dpkg-query will fail on the virtual package and so --compare-versions won't get invoked.
However, it occurs to me we don't deal with the rename to xul-ext-ubufox. Now, so far this has been fine, since there's been a transitional package since Karmic, and it's still there in Quantal. And it shouldn't be possible to have a machine that goes from a broken version on Hardy directly to, say, Zany Zebra, but still, I wonder if we need to deal?
-Jon
On Jul 10, 2012, at 10:31 AM, Benjamin Kaduk wrote:
> Such fun.
> Note that "dpkg-query -W -f '${Version}' ${package}" returns success and prints the empty string if ${package} is a virtual package; perhaps we want ge-nl? Otherwise looks good.
> -Ben
>
> On Sun, 8 Jul 2012, Jonathan D Reed wrote:
>
>> Author: jdreed
>> Date: 2012-07-08 16:43:11 -0400 (Sun, 08 Jul 2012)
>> New Revision: 25625
>>
>> Modified:
>> trunk/athena/lib/firefox-extension/debian/changelog
>> trunk/athena/lib/firefox-extension/debian/debathena-firefox-extension.postinst
>> Log:
>> In firefox-extension:
>> * dpkg-query returns non-zero if a package doesn't exist
>>
>>
>> Modified: trunk/athena/lib/firefox-extension/debian/changelog
>> ===================================================================
>> --- trunk/athena/lib/firefox-extension/debian/changelog 2012-07-08 18:02:31 UTC (rev 25624)
>> +++ trunk/athena/lib/firefox-extension/debian/changelog 2012-07-08 20:43:11 UTC (rev 25625)
>> @@ -1,3 +1,9 @@
>> +debathena-firefox-extension (10.1-0debathena4) unstable; urgency=low
>> +
>> + * dpkg-query returns non-zero if a package doesn't exist
>> +
>> + -- Jonathan Reed <jdreed@mit.edu> Sun, 08 Jul 2012 16:44:36 -0400
>> +
>> debathena-firefox-extension (10.1-0debathena3) unstable; urgency=low
>>
>> * Don't symlink onto something that exists
>>
>> Modified: trunk/athena/lib/firefox-extension/debian/debathena-firefox-extension.postinst
>> ===================================================================
>> --- trunk/athena/lib/firefox-extension/debian/debathena-firefox-extension.postinst 2012-07-08 18:02:31 UTC (rev 25624)
>> +++ trunk/athena/lib/firefox-extension/debian/debathena-firefox-extension.postinst 2012-07-08 20:43:11 UTC (rev 25625)
>> @@ -26,8 +26,7 @@
>> configure)
>> # In 0.9~rc2-0ubuntu2, the conffile moved to /etc/xul-ext
>> # and we horribly broke things. Let's attempt to unbreak them:
>> - ubufox_version="$(dpkg-query -W -f '${Version}' ubufox)"
>> - if dpkg --compare-versions "$ubufox_version" ge "0.9~rc2-0ubuntu2" && [ -d /etc/firefox-3.0/pref ]; then
>> + if dpkg-query -W ubufox 2>/dev/null 2>&1 && dpkg --compare-versions "$(dpkg-query -W -f '${Version}' ubufox)" ge "0.9~rc2-0ubuntu2" && [ -d /etc/firefox-3.0/pref ]; then
>> # The file should have been undiverted at this point
>> echo "*** The previous OMINOUS WARNING may be safely ignored ***" >&2
>> # If there are files in the location, move them to
>>
>>
