[26512] in Source-Commits
Re: /svn/athena r25593 - trunk/debathena/debathena/dotfiles
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Mon Jul 2 09:49:36 2012
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1207012341020.18441@multics.mit.edu>
Date: Mon, 2 Jul 2012 09:49:33 -0400
Cc: source-commits@MIT.EDU
Message-Id: <924890C1-6188-46CC-91A7-1954ACD76B35@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
>> + echo $path | /usr/bin/tr ':' '\n' | /bin/grep -Fqx /bin
>> + [ $? = 0 ] || missing=1
>> + echo $path | /usr/bin/tr ':' '\n' | /bin/grep -Fqx /usr/bin
>> + [ $? = 0 ] || missing=1
>
> These calls to test(1) want '-eq' (not '='), right?
Both work, but -eq is more correct.
>> + if [ $missing -eq 1 ]; then
>> + text="You appear to have incorrectly modified your PATH variable in your dotfiles,\nand as such have deleted /bin and/or /usr/bin from your PATH, which\nwill likely cause this login session to fail. Please correct this problem.\nYou can set the skip_sanity_checks variable to disable this message."
>
> We mention .bashrc.mine for the LD_ASSUME_KERNEL bit, but not here. Not sure whether we care... (if we do, the csh version needs it, too).
>
> This is different than the text in the bash version. Probably the bash version is better.
Fixed.
