[26477] in Source-Commits
Re: /svn/athena r25562 - trunk/debathena/scripts
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Jun 26 20:05:12 2012
Date: Tue, 26 Jun 2012 20:05:07 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <BC13C45A-AF1C-4CFB-8E9A-55515611EFD8@MIT.EDU>
Message-ID: <alpine.GSO.1.10.1206262002330.18441@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Tue, 26 Jun 2012, Jonathan Reed wrote:
>>> case "${1}/${2}" in
>>> /-proposed) ;;
>>> /-development) ;;
>>>
>>> Modified: trunk/debathena/scripts/daupload-proposed
>>> ===================================================================
>>> --- trunk/debathena/scripts/daupload-proposed 2012-06-04 16:15:42 UTC (rev 25561)
>>> +++ trunk/debathena/scripts/daupload-proposed 2012-06-05 14:33:06 UTC (rev 25562)
>>> @@ -29,6 +29,9 @@
>>> daupload-dev)
>>> release="-development"
>>> ;;
>>> + daupload-bleeding)
>>> + release="-bleeding"
>>> + ;;
>>> *)
>>> echo "Unknown release." >&2
>>> exit 1
>>>
>>>
>>
>> I do not think this is correct.
>> The case block is on "$(basename "$0")", which will still be daupload-proposed. It looks like we try to change all the daupload-* in lockstep, and you would just want to add another copy of the file with the new name, and make the change everywhere.
>> (It's less clear if not documenting it in the Usage comment at the top is advisable or not.)
>
> Only if we're running it as daupload-proposed, and we won't be. I'll
> create the daupload-bleeding symlink. (See also, daupload-dev). It's
> possible that the symlink target shouldn't be the -proposed version, but
> it is.
Hmm, I had missed that -dev was a symlink even in the repo, only that both
existed in the repo and were identical. That would work.
Sorry for the confusion,
Ben
