[26475] in Source-Commits
Re: /svn/athena r25562 - trunk/debathena/scripts
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Tue Jun 26 14:00:36 2012
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1206122239320.18441@multics.mit.edu>
Date: Tue, 26 Jun 2012 14:00:31 -0400
Cc: source-commits@MIT.EDU
Message-Id: <BC13C45A-AF1C-4CFB-8E9A-55515611EFD8@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
>> case "${1}/${2}" in
>> /-proposed) ;;
>> /-development) ;;
>>
>> Modified: trunk/debathena/scripts/daupload-proposed
>> ===================================================================
>> --- trunk/debathena/scripts/daupload-proposed 2012-06-04 16:15:42 UTC (rev 25561)
>> +++ trunk/debathena/scripts/daupload-proposed 2012-06-05 14:33:06 UTC (rev 25562)
>> @@ -29,6 +29,9 @@
>> daupload-dev)
>> release="-development"
>> ;;
>> + daupload-bleeding)
>> + release="-bleeding"
>> + ;;
>> *)
>> echo "Unknown release." >&2
>> exit 1
>>
>>
>
> I do not think this is correct.
> The case block is on "$(basename "$0")", which will still be daupload-proposed. It looks like we try to change all the daupload-* in lockstep, and you would just want to add another copy of the file with the new name, and make the change everywhere.
> (It's less clear if not documenting it in the Usage comment at the top is advisable or not.)
Only if we're running it as daupload-proposed, and we won't be. I'll create the daupload-bleeding symlink. (See also, daupload-dev). It's possible that the symlink target shouldn't be the -proposed version, but it is.
-Jon
