[26457] in Source-Commits
Re: /svn/athena r25562 - trunk/debathena/scripts
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Tue Jun 12 22:48:59 2012
Date: Tue, 12 Jun 2012 22:48:54 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201206051433.q55EX7td007777@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1206122239320.18441@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII
On Tue, 5 Jun 2012, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2012-06-05 10:33:06 -0400 (Tue, 05 Jun 2012)
> New Revision: 25562
>
> Modified:
> trunk/debathena/scripts/dacopy
> trunk/debathena/scripts/daupload-proposed
> Log:
> Support -bleeding repository
>
> Modified: trunk/debathena/scripts/dacopy
> ===================================================================
> --- trunk/debathena/scripts/dacopy 2012-06-04 16:15:42 UTC (rev 25561)
> +++ trunk/debathena/scripts/dacopy 2012-06-05 14:33:06 UTC (rev 25562)
> @@ -15,6 +15,13 @@
> exit 1
> fi
>
> +if [ "$1" = "-bleeding" ] || [ "$2" = "-bleeding" ]; then
> + echo "You're not supposed to move or copy things to or from -bleeding."
> + echo "Exiting..."
> + exit 1
> +fi
> +
> +
This looks good.
> case "${1}/${2}" in
> /-proposed) ;;
> /-development) ;;
>
> Modified: trunk/debathena/scripts/daupload-proposed
> ===================================================================
> --- trunk/debathena/scripts/daupload-proposed 2012-06-04 16:15:42 UTC (rev 25561)
> +++ trunk/debathena/scripts/daupload-proposed 2012-06-05 14:33:06 UTC (rev 25562)
> @@ -29,6 +29,9 @@
> daupload-dev)
> release="-development"
> ;;
> + daupload-bleeding)
> + release="-bleeding"
> + ;;
> *)
> echo "Unknown release." >&2
> exit 1
>
>
I do not think this is correct.
The case block is on "$(basename "$0")", which will still be
daupload-proposed. It looks like we try to change all the daupload-* in
lockstep, and you would just want to add another copy of the file with the
new name, and make the change everywhere.
(It's less clear if not documenting it in the Usage comment at the top is
advisable or not.)
-Ben
