[26396] in Source-Commits
Re: /svn/athena r25545 -
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sat Jun 2 16:25:48 2012
Date: Sat, 2 Jun 2012 16:25:44 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201206011533.q51FXI0g021355@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1206021625400.18441@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
ACK.
-Ben
On Fri, 1 Jun 2012, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2012-06-01 11:33:18 -0400 (Fri, 01 Jun 2012)
> New Revision: 25545
>
> Modified:
> trunk/debathena/config/lightdm-config/debian/changelog
> trunk/debathena/config/lightdm-config/debian/debathena-lightdm-greeter
> Log:
> In lightdm-config:
> * The show-message callback takes 3 args, not 2.
>
>
> Modified: trunk/debathena/config/lightdm-config/debian/changelog
> ===================================================================
> --- trunk/debathena/config/lightdm-config/debian/changelog 2012-06-01 04:40:46 UTC (rev 25544)
> +++ trunk/debathena/config/lightdm-config/debian/changelog 2012-06-01 15:33:18 UTC (rev 25545)
> @@ -5,8 +5,9 @@
> were in an additional window and could obscure the greeter
> * Disallow logins when we're taking an update
> * Explain how to type a username correctly
> + * The show-message callback takes 3 args, not 2.
>
> - -- Jonathan Reed <jdreed@mit.edu> Thu, 31 May 2012 09:17:59 -0400
> + -- Jonathan Reed <jdreed@mit.edu> Fri, 01 Jun 2012 11:32:08 -0400
>
> debathena-lightdm-config (1.0) unstable; urgency=low
>
>
> Modified: trunk/debathena/config/lightdm-config/debian/debathena-lightdm-greeter
> ===================================================================
> --- trunk/debathena/config/lightdm-config/debian/debathena-lightdm-greeter 2012-06-01 04:40:46 UTC (rev 25544)
> +++ trunk/debathena/config/lightdm-config/debian/debathena-lightdm-greeter 2012-06-01 15:33:18 UTC (rev 25545)
> @@ -320,17 +320,19 @@
> self.spin(False)
>
> # show-message is emitted when LightDM has something to say to the user
> - # In testing, I have never encountered this. Note that this is _not_
> - # "authentication failed", as far as I can tell. Some docs imply
> - # that is is for those types of messages or PAM messages, but that
> - # contradicts the docs which say to check .is_authenticated() in
> - # the authentication-complete callback to determine login success or
> - # failure. "Whatever".
> + # Typically, these are emitted by PAM modules (e.g. pam_echo)
> + # Note that this is _not_ "authentication failed" (unless a PAM module
> + # specifically says that).
> + #
> + # The docs which say to check .is_authenticated() in the
> + # authentication-complete callback to determine login success or
> + # failure.
> #
> - # In theory, messageType is one of LightDM.MessageType.{ERROR,INFO}
> - def cbShowMessage(self, text, messageType):
> + # messageType is one of LightDM.MessageType.{ERROR,INFO}
> + def cbShowMessage(self, greeter, text, messageType):
> self._debug("cbShowMessage: Received show-messsage message",
> text, messageType)
> + # TODO: Wrap text
> self.displayMessage(text)
> self.spin(False)
>
>
>
