[26264] in Source-Commits
Re: /svn/athena r25476 - trunk/debathena/scripts
daemon@ATHENA.MIT.EDU (Geoffrey Thomas)
Mon May 7 15:43:12 2012
Date: Mon, 7 May 2012 12:43:10 -0700 (PDT)
From: Geoffrey Thomas <geofft@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <1BC924D9-7D75-496F-BF7C-04D4429E1201@mit.edu>
Message-ID: <alpine.DEB.2.00.1205071242200.25644@dr-wily.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Mon, 7 May 2012, Jonathan Reed wrote:
>>> + if echo $i | grep -q '\.dsc$'; then
>>> + dscfile=$i
>>> + fi
>>> +done
>>
>> This seems like a kind of strange algorithm. Why are we not shifting
>> out the other arguments?
>
> Because then I get to shift out -A and re-add it? This algorithm picks
> the last .dsc file specified on the command line. It's not clear to me
> that shifting out the arguments, and then re-adding them is noticeably
> better.
OK, I thought we'd want the argument already.
Although come to think about it, this is potentially the best we can do,
since da has until now been argument-agnostic.
--
Geoffrey Thomas
geofft@mit.edu
