[26261] in Source-Commits
Re: /svn/athena r25476 - trunk/debathena/scripts
daemon@ATHENA.MIT.EDU (Geoffrey Thomas)
Mon May 7 15:30:45 2012
Date: Mon, 7 May 2012 12:30:43 -0700 (PDT)
From: Geoffrey Thomas <geofft@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201205071627.q47GRX7g008659@drugstore.mit.edu>
Message-ID: <alpine.DEB.2.00.1205071225160.19587@dr-wily.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Mon, 7 May 2012, Jonathan D Reed wrote:
> -# If ./nobuild exists, filter out its contents from DEBIAN_CODES.
> -if [ -e nobuild ]; then
> +# Adjust DEBIAN_CODES based on Debathena-Build-For or Debathena-No-Build
> +if [ -n "$BUILDFOR" ]; then
> + DEBIAN_CODES=$BUILDFOR
> +elif [ -n "$NOBUILD" ]; then
> newcodes=
> for code in $DEBIAN_CODES; do
> - if ! fgrep -q "$code" nobuild; then
> + if ! echo $NOBUILD | fgrep -q "$code"; then
> newcodes="$newcodes $code"
> fi
> done
Quote, please. Alternatively
for code in $DEBIAN_CODES; do
case $NOBUILD in
*$code*) ... ;;
or something.
Speaking of which, to be clear, the format here is space-delimited release
names? (We should be more clever about releases whose names are substrings
of other releases, at the very least so we can do things like
precise-backports if we ever want to support something like that, but
that's not a regression from the current code.)
> +dscfile=
> +for i in $@; do
Quote.
> + if echo $i | grep -q '\.dsc$'; then
> + dscfile=$i
> + fi
> +done
This seems like a kind of strange algorithm. Why are we not shifting out
the other arguments?
--
Geoffrey Thomas
geofft@mit.edu
