[26230] in Source-Commits
Re: /svn/athena r25462 - in
daemon@ATHENA.MIT.EDU (John Hawkinson)
Thu Apr 19 19:54:05 2012
Date: Thu, 19 Apr 2012 19:54:01 -0400
From: John Hawkinson <jhawk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
Cc: source-commits@MIT.EDU
Message-ID: <20120419235401.GH11594@multics.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6F87D3F7-C52A-412D-A75D-675D219489FB@mit.edu>
Jonathan Reed <jdreed@MIT.EDU> wrote on Thu, 19 Apr 2012
at 17:05:38 -0400 in <6F87D3F7-C52A-412D-A75D-675D219489FB@mit.edu>:
> > In any case, the message that ERR is "unknown" is wrong, so we should change that.
>
> I agree. I think it can be as simple as:
>
> > ++ if pointer['type'] == 'ERR':
> > ++ syslog(LOG_INFO, "Locker "+name+" has been deactivated. Contact accounts@mit.edu with questions.")
> > ++ return None
Huh? Shouldn't it provide the actual error message associated with the
ERR, rather than hardcoding something. E.g.:
[multics!jhawk] ~> hesinfo newman filsys
ERR Locker deactivated; contact 253-1325 for help
[multics!jhawk] ~>
Now, maybe the ERR messages should include an email address in addition
to 3-1325, but that doesn't seem the province of pyhesiodfs.
--jhawk
