[26228] in Source-Commits
Re: /svn/athena r25462 - in trunk/debathena/debathena/pyhesiodfs/debian:
daemon@ATHENA.MIT.EDU (Geoffrey Thomas)
Thu Apr 19 16:55:52 2012
Date: Thu, 19 Apr 2012 13:55:49 -0700 (PDT)
From: Geoffrey Thomas <geofft@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: Alex Dehnert <adehnert@MIT.EDU>, source-commits@MIT.EDU
In-Reply-To: <84FD336A-E707-4309-AF88-2A5F9C3589C7@MIT.EDU>
Message-ID: <alpine.DEB.2.02.1204191354020.24758@tyger.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
I don't think we have a plausible way of ever getting those messages to
the end user, and I also disagree that the messages are ever helpful --
knowing that a locker was deactivated with a generic message isn't too
different from just knowing it doesn't exist.
As an end user, if I get an ENOENT on a directory in /mit, I'll run
hesinfo or attach or add or something to see what's up long before I ask
my sysadmin to go look in /var/log/syslog.
In any case, the message that ERR is "unknown" is wrong, so we should
change that.
--
Geoffrey Thomas
geofft@mit.edu
On Thu, 19 Apr 2012, Jonathan Reed wrote:
> "Oh". Then, NAK on the original patch. The message is helpful, especially since we're trying to discourage people from typing "attach". Do it at LOG_INFO or something if you don't want Linerva to zephyr.
>
>
> On Apr 19, 2012, at 4:28 PM, Alex Dehnert wrote:
>
>> So, *Linerva* doesn't want to *zephyr* any syslogs. My suspicion is that
>> Geoff went "huh, this message is useless, I'll just kill it in
>> pyhesiodfs". I don't think Linerva, at least, particularly cares about
>> whether the syslogs get generated (so long as any that do can be
>> excluded from zephyring by our config).
>>
>> Beyond that... whatever makes people happiest. My suspicion is that
>> that's "syslog with the full message [usually "contact accounts"?], and
>> probably in a way that doesn't sound like we've never heard of ERR", but
>> dunno.
>>
>> ~~Alex
>>
>> On 04/19/2012 11:10 AM, Jonathan Reed wrote:
>>> Was the goal here to actually not send any syslogs, or was it to stop syslogging "unknown locker type" for ERR lockers. The previous behavior was definitely wrong, but it's not clear to me that this fix is necessarily better than simply sysloging "Deactivated locker $foo, contact accounts with questions".
>>>
>>> This is not strictly speaking a NAK, but I want us to be clear about what we're trying to change.
>>>
>>> Having (unfortunately) read through the entire zephyr thread, I think this is probably ok (a deactivated locker kind of doesn't exist), but it sounds like enough people have concerns that we should discuss them further over e-mail. There are plenty of things that spew crap into syslog, that a few "This locker is deactivated, love, IS&T" syslogs won't be the end of the world and might help...
>>>
>>> -Jon
>>>
>>> On Apr 2, 2012, at 4:56 PM, Geoffrey Thomas wrote:
>>>
>>>> Author: geofft
>>>> Date: 2012-04-02 16:56:47 -0400 (Mon, 02 Apr 2012)
>>>> New Revision: 25462
>>>>
>>>> Added:
>>>> trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch
>>>> Modified:
>>>> trunk/debathena/debathena/pyhesiodfs/debian/changelog
>>>> trunk/debathena/debathena/pyhesiodfs/debian/patches/series
>>>> Log:
>>>> In pyhesiodfs:
>>>> * Don't send syslog messages on ERR locker types.
>>>>
>>>>
>>>> Modified: trunk/debathena/debathena/pyhesiodfs/debian/changelog
>>>> ===================================================================
>>>> --- trunk/debathena/debathena/pyhesiodfs/debian/changelog 2012-03-28 18:58:19 UTC (rev 25461)
>>>> +++ trunk/debathena/debathena/pyhesiodfs/debian/changelog 2012-04-02 20:56:47 UTC (rev 25462)
>>>> @@ -1,3 +1,9 @@
>>>> +debathena-pyhesiodfs (0.0.r167-0debathena10) unstable; urgency=low
>>>> +
>>>> + * Don't send syslog messages on ERR locker types.
>>>> +
>>>> + -- Geoffrey Thomas <geofft@mit.edu> Mon, 02 Apr 2012 13:51:57 -0700
>>>> +
>>>> debathena-pyhesiodfs (0.0.r167-0debathena9) unstable; urgency=low
>>>>
>>>> * No change rebuild to pick up config-package-dev 4.13 changes
>>>>
>>>> Added: trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch
>>>> ===================================================================
>>>> --- trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch (rev 0)
>>>> +++ trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch 2012-04-02 20:56:47 UTC (rev 25462)
>>>> @@ -0,0 +1,13 @@
>>>> +Index: pyHesiodFS.py
>>>> +===================================================================
>>>> +--- pyhesiodfs/pyHesiodFS.py (revision 25441)
>>>> ++++ pyhesiodfs/pyHesiodFS.py (working copy)
>>>> +@@ -176,6 +176,8 @@
>>>> + if len(filsys.filsys) >= 1:
>>>> + pointers = filsys.filsys
>>>> + pointer = pointers[0]
>>>> ++ if pointer['type'] == 'ERR':
>>>> ++ return None
>>>> + if pointer['type'] != 'AFS' and pointer['type'] != 'LOC':
>>>> + syslog(LOG_NOTICE, "Unknown locker type "+pointer['type']+" for locker "+name+" ("+repr(pointer)+" )")
>>>> + return None
>>>>
>>>> Modified: trunk/debathena/debathena/pyhesiodfs/debian/patches/series
>>>> ===================================================================
>>>> --- trunk/debathena/debathena/pyhesiodfs/debian/patches/series 2012-03-28 18:58:19 UTC (rev 25461)
>>>> +++ trunk/debathena/debathena/pyhesiodfs/debian/patches/series 2012-04-02 20:56:47 UTC (rev 25462)
>>>> @@ -1,2 +1,3 @@
>>>> install-script-without-extension.patch
>>>> no-hello.patch
>>>> +no-syslog-on-ERR.patch
>>>>
>
>
