[26225] in Source-Commits
Re: /svn/athena r25462 - in trunk/debathena/debathena/pyhesiodfs/debian: . patches
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Thu Apr 19 11:10:46 2012
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <201204022056.q32KulhW021188@drugstore.mit.edu>
Date: Thu, 19 Apr 2012 11:10:42 -0400
Cc: source-commits@MIT.EDU
Message-Id: <2B32A442-316E-46EB-9080-651BCAD8058C@mit.edu>
To: Geoffrey Thomas <geofft@MIT.EDU>
Content-Transfer-Encoding: 8bit
Was the goal here to actually not send any syslogs, or was it to stop syslogging "unknown locker type" for ERR lockers. The previous behavior was definitely wrong, but it's not clear to me that this fix is necessarily better than simply sysloging "Deactivated locker $foo, contact accounts with questions".
This is not strictly speaking a NAK, but I want us to be clear about what we're trying to change.
Having (unfortunately) read through the entire zephyr thread, I think this is probably ok (a deactivated locker kind of doesn't exist), but it sounds like enough people have concerns that we should discuss them further over e-mail. There are plenty of things that spew crap into syslog, that a few "This locker is deactivated, love, IS&T" syslogs won't be the end of the world and might help...
-Jon
On Apr 2, 2012, at 4:56 PM, Geoffrey Thomas wrote:
> Author: geofft
> Date: 2012-04-02 16:56:47 -0400 (Mon, 02 Apr 2012)
> New Revision: 25462
>
> Added:
> trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch
> Modified:
> trunk/debathena/debathena/pyhesiodfs/debian/changelog
> trunk/debathena/debathena/pyhesiodfs/debian/patches/series
> Log:
> In pyhesiodfs:
> * Don't send syslog messages on ERR locker types.
>
>
> Modified: trunk/debathena/debathena/pyhesiodfs/debian/changelog
> ===================================================================
> --- trunk/debathena/debathena/pyhesiodfs/debian/changelog 2012-03-28 18:58:19 UTC (rev 25461)
> +++ trunk/debathena/debathena/pyhesiodfs/debian/changelog 2012-04-02 20:56:47 UTC (rev 25462)
> @@ -1,3 +1,9 @@
> +debathena-pyhesiodfs (0.0.r167-0debathena10) unstable; urgency=low
> +
> + * Don't send syslog messages on ERR locker types.
> +
> + -- Geoffrey Thomas <geofft@mit.edu> Mon, 02 Apr 2012 13:51:57 -0700
> +
> debathena-pyhesiodfs (0.0.r167-0debathena9) unstable; urgency=low
>
> * No change rebuild to pick up config-package-dev 4.13 changes
>
> Added: trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch
> ===================================================================
> --- trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch (rev 0)
> +++ trunk/debathena/debathena/pyhesiodfs/debian/patches/no-syslog-on-ERR.patch 2012-04-02 20:56:47 UTC (rev 25462)
> @@ -0,0 +1,13 @@
> +Index: pyHesiodFS.py
> +===================================================================
> +--- pyhesiodfs/pyHesiodFS.py (revision 25441)
> ++++ pyhesiodfs/pyHesiodFS.py (working copy)
> +@@ -176,6 +176,8 @@
> + if len(filsys.filsys) >= 1:
> + pointers = filsys.filsys
> + pointer = pointers[0]
> ++ if pointer['type'] == 'ERR':
> ++ return None
> + if pointer['type'] != 'AFS' and pointer['type'] != 'LOC':
> + syslog(LOG_NOTICE, "Unknown locker type "+pointer['type']+" for locker "+name+" ("+repr(pointer)+" )")
> + return None
>
> Modified: trunk/debathena/debathena/pyhesiodfs/debian/patches/series
> ===================================================================
> --- trunk/debathena/debathena/pyhesiodfs/debian/patches/series 2012-03-28 18:58:19 UTC (rev 25461)
> +++ trunk/debathena/debathena/pyhesiodfs/debian/patches/series 2012-04-02 20:56:47 UTC (rev 25462)
> @@ -1,2 +1,3 @@
> install-script-without-extension.patch
> no-hello.patch
> +no-syslog-on-ERR.patch
>
