[26207] in Source-Commits
Re: /svn/athena r25454 r25452 -
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Fri Feb 17 14:11:52 2012
Date: Fri, 17 Feb 2012 14:11:47 -0500 (EST)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201202171910.q1HJAX0C005086@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1202171411170.26794@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
ACK this and r25452
Thanks for the update.
-Ben
On Fri, 17 Feb 2012, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2012-02-17 14:10:33 -0500 (Fri, 17 Feb 2012)
> New Revision: 25454
>
> Modified:
> trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
> Log:
> Only remove Realtek NIC firmware requests, not all of them
>
> Modified: trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
> ===================================================================
> --- trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh 2012-02-15 21:04:21 UTC (rev 25453)
> +++ trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh 2012-02-17 19:10:33 UTC (rev 25454)
> @@ -9,7 +9,11 @@
> # because check-missing-firmware still insists on reloading the module
> # and we lose the network configuration.
> if grep -q "^Vostro 320" /sys/class/dmi/id/product_name || lsmod | grep -q r8169; then
> - rm -f /dev/.udev/firmware-missing/*
> + # This will break if the firmware eventually wants to live somewhere else
> + # This is possibly a bad idea if there are r8169-based cards that do need
> + # firmware, but if they do, it's not likely they made it this far in the
> + # installation process.
> + rm -f /dev/.udev/firmware-missing/rtl_nic*
> fi
>
> cd /debathena
>
>
