[26202] in Source-Commits
Re: /svn/athena r25452 -
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Thu Feb 16 15:30:30 2012
Date: Thu, 16 Feb 2012 15:30:27 -0500 (EST)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan D Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <201202151813.q1FIDsDr014033@drugstore.mit.edu>
Message-ID: <alpine.GSO.1.10.1202161529070.26794@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Wed, 15 Feb 2012, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2012-02-15 13:13:53 -0500 (Wed, 15 Feb 2012)
> New Revision: 25452
>
> Modified:
> trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
> Log:
> A better solution for the Vostro/r8169 problem.
>
> Modified: trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
> ===================================================================
> --- trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh 2012-02-14 21:34:55 UTC (rev 25451)
> +++ trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh 2012-02-15 18:13:53 UTC (rev 25452)
> @@ -1,9 +1,15 @@
> #!/bin/sh
>
> -# Live Poultry Fresh Killed
> -if grep -q "^Vostro 320" /sys/class/dmi/id/product_name; then
> - echo "Scribbling over check-missing-firmware"
> - echo > /bin/check-missing-firmware
> +# Sigh. check-missing-firmware is too stupid to reconfigure the NIC after
> +# removing and reloading the module. So we lose network in the middle
> +# of the install. The card works just fine without firmware, so we
> +# just convince hwdetect and friends that there is no missing firmware.
> +# NOTE: Although the nic-firmware udeb does not include the Realtek
> +# firmware, shipping the firmware ourselves does not fix the problem,
> +# because check-missing-firmware still insists on reloading the module
> +# and we lose the network configuration.
> +if grep -q "^Vostro 320" /sys/class/dmi/id/product_name || lsmod | grep -q r8169; then
> + rm -f /dev/.udev/firmware-missing/*
Not having one of these hardwares on me, what does that directory
structure look like? Are the files within it empty or do they contain
content?
(I worry that someone could get screwed over if they have a realtek nic
and say a video card that actually needs firmware.)
-Ben
