[26061] in Source-Commits
Re: /svn/athena r25369 - trunk/debathena/config/cupsys-config/debian
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Wed Aug 10 18:34:19 2011
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.DEB.2.00.1108101810410.14232@tyger.mit.edu>
Date: Wed, 10 Aug 2011 18:34:12 -0400
Cc: source-commits@mit.edu
Message-Id: <E37CB686-8C81-4D8C-BB72-E7E3C8C909EA@mit.edu>
To: Geoffrey Thomas <geofft@mit.edu>
Content-Transfer-Encoding: 8bit
Isn't that what manual-config is for? I can't think of a good reason for "I want the MIT printers, but don't ever want to set any default printer, ever" where "Go run manual-config or suck it up" isn't the right answer. I know Debathena is all about flexibility, but there has to be a line, otherwise we wouldn't have manual-config at all.
On Aug 10, 2011, at 6:11 PM, Geoffrey Thomas wrote:
> I take that back. Can you make this only run this code on upgrade from the preceding version or before, as opposed to on every install? If the user wants to explicitly have no default printer, they shouldn't have to reset that setting every time they upgrade cupsys-config.
>
> --
> Geoffrey Thomas
> geofft@mit.edu
>
> On Wed, 10 Aug 2011, Geoffrey Thomas wrote:
>
>> ACK this and the previous commit.
>>
>> --
>> Geoffrey Thomas
>> geofft@mit.edu
>>
>> On Wed, 10 Aug 2011, Jonathan D Reed wrote:
>>
>>> Author: jdreed
>>> Date: 2011-08-10 17:59:25 -0400 (Wed, 10 Aug 2011)
>>> New Revision: 25369
>>> Modified:
>>> trunk/debathena/config/cupsys-config/debian/configure-athena-printers
>>> Log:
>>> Use the variable for the default printer
>>> Modified: trunk/debathena/config/cupsys-config/debian/configure-athena-printers
>>> ===================================================================
>>> --- trunk/debathena/config/cupsys-config/debian/configure-athena-printers 2011-08-10 21:56:31 UTC (rev 25368)
>>> +++ trunk/debathena/config/cupsys-config/debian/configure-athena-printers 2011-08-10 21:59:25 UTC (rev 25369)
>>> @@ -33,7 +33,7 @@
>>> # There exist return codes. Use them.
>>> # Love, Debathena
>>> if [ "$(lpstat -d)" = "no system default destination" ]; then
>>> - lpadmin -d mitprint
>>> + lpadmin -d $DEFAULT_PRINTER
>>> fi
>>> # We don't need to deal with this on uninstall. CUPS is
>>> # smart enough (for now, at least) to not retain a default when
>>
