[25984] in Source-Commits
Re: /svn/athena r25318 - in trunk/debathena/config/printing-config:
daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sat Jul 30 21:17:13 2011
Date: Sat, 30 Jul 2011 21:17:05 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <alpine.GSO.1.10.1107301657550.7526@multics.mit.edu>
Message-ID: <alpine.GSO.1.10.1107302116540.7526@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Sat, 30 Jul 2011, Benjamin Kaduk wrote:
> On Sat, 30 Jul 2011, Jonathan Reed wrote:
>
>>>> + if server == None and common.get_cups_uri(queue) == None:
>>>> + # if there's no Hesiod server and no local queue,
>>>> + # tell the user they're wrong
>>>> + # But let it fall through in case the user is doing
>>>> + # stupid things with -h
>>>
>>> lpr is dumb and uses -H for the host.
>>>
>>> -Ben
>>>
>>
>> Fair enough, but we're not actually looking at the args. The point was
>> simply not to call common.error(). This means if a user is repeatedly
>> calling -h/-H or setting CUPS_SERVER, they may get a bunch of spurious
>> warnings. I can't convince myself that this is a problem.
>
> I can't, either; I was just pointing out the copy-and-paste-o.
(But ACK anyway.)
-Ben
