[25982] in Source-Commits

home help back first fref pref prev next nref lref last post

Re: /svn/athena r25318 - in trunk/debathena/config/printing-config:

daemon@ATHENA.MIT.EDU (Benjamin Kaduk)
Sat Jul 30 16:58:28 2011

Date: Sat, 30 Jul 2011 16:58:20 -0400 (EDT)
From: Benjamin Kaduk <kaduk@MIT.EDU>
To: Jonathan Reed <jdreed@MIT.EDU>
cc: source-commits@MIT.EDU
In-Reply-To: <0A489C25-D66C-43C9-98AE-01B12B832BD3@MIT.EDU>
Message-ID: <alpine.GSO.1.10.1107301657550.7526@multics.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed

On Sat, 30 Jul 2011, Jonathan Reed wrote:

>>> +    if server == None and common.get_cups_uri(queue) == None:
>>> +        # if there's no Hesiod server and no local queue,
>>> +        # tell the user they're wrong
>>> +        # But let it fall through in case the user is doing
>>> +        # stupid things with -h
>>
>> lpr is dumb and uses -H for the host.
>>
>> -Ben
>>
>
> Fair enough, but we're not actually looking at the args.  The point was simply not to call common.error().  This means if a user is repeatedly calling -h/-H or setting CUPS_SERVER, they may get a bunch of spurious warnings.  I can't convince myself that this is a problem.

I can't, either; I was just pointing out the copy-and-paste-o.

-Ben

home help back first fref pref prev next nref lref last post