[25821] in Source-Commits

home help back first fref pref prev next nref lref last post

Re: /svn/athena r25246, r25247 - trunk/debathena/scripts/installer/pxe/natty/debathena

daemon@ATHENA.MIT.EDU (Jonathan Reed)
Sat Jul 16 19:55:15 2011

Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1107161831320.6818@multics.mit.edu>
Date: Sat, 16 Jul 2011 19:55:07 -0400
Cc: Geoffrey Thomas <geofft@mit.edu>, source-commits@mit.edu
Message-Id: <D9800741-AE54-4804-93C8-F97284D16795@mit.edu>
To: Benjamin Kaduk <kaduk@mit.edu>
Content-Transfer-Encoding: 8bit

==

I'm not sure what you're trying to fix in this commit?

On Jul 16, 2011, at 6:32 PM, Benjamin Kaduk wrote:

> It doesn't look like NETMASK and GATEWAY will be set in this codepath.
> Moving the logic to set them down here may or may not be what we want.
> 
> -Ben
> 
> On Sat, 16 Jul 2011, Geoffrey Thomas wrote:
> 
>> Author: geofft
>> Date: 2011-07-16 18:25:03 -0400 (Sat, 16 Jul 2011)
>> New Revision: 25247
>> 
>> Modified:
>>  trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
>> Log:
>> Fix mistake in r25246
>> 
>> Modified: trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh
>> ===================================================================
>> --- trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh	2011-07-16 21:52:09 UTC (rev 25246)
>> +++ trunk/debathena/scripts/installer/pxe/natty/debathena/installer.sh	2011-07-16 22:25:03 UTC (rev 25247)
>> @@ -102,15 +102,15 @@
>> if [ -n "$clusteraddr" ] && [ "$nodhcp" != "true" ]; then
>>  IPADDR=$clusteraddr
>>  netconfig
>> -  echo "Saving preseed netcfg values"
>> -  cat >> preseed <<EOF
>> +fi
>> +echo "Saving preseed netcfg values"
>> +cat >> preseed <<EOF
>> d-i netcfg/get_nameservers string 18.72.0.3
>> d-i netcfg/get_ipaddress string $IPADDR
>> d-i netcfg/get_netmask string $NETMASK
>> d-i netcfg/get_gateway string $GATEWAY
>> d-i netcfg/confirm_static boolean true
>> EOF
>> -fi
>> 
>> # We're at a point in the install process where we can be fairly sure
>> # that nothing else is happening, so "killall wget" should be safe.
>> 
>> 



home help back first fref pref prev next nref lref last post