[25751] in Source-Commits
Re: /svn/athena r25207 - trunk/debathena/scripts/installer/pxe/stage1/debathena
daemon@ATHENA.MIT.EDU (Jonathan Reed)
Sat Jul 2 20:46:28 2011
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Jonathan Reed <jdreed@MIT.EDU>
In-Reply-To: <alpine.GSO.1.10.1107021943590.6818@multics.mit.edu>
Date: Sat, 2 Jul 2011 20:46:21 -0400
Cc: source-commits@MIT.EDU
Message-Id: <434D2C64-9A1B-4C2C-8C9A-6CB616D6D514@MIT.EDU>
To: Benjamin Kaduk <kaduk@MIT.EDU>
Content-Transfer-Encoding: 8bit
> The dnscgi usage tells me that only 'A' and 'PTR' are acceptable!
Undocumented yet functional arguments are the hallmark of open source projects.
>> + if echo $dig | grep -q '^OK:'; then
>> + IPADDR="$(echo "$dig" | sed 's/^OK: //')"
>> + echo "Found $IPADDR..."
>> + else
>> + echo $dig
>
> This one should perhaps have quotes, though. (echo only takes one argument, so injection isn't really an issue. But it is foreign input. "For the whitespace-preservation, Montressor!")
I'll add the quotes here and below and push this out next week.
-Jon
