[25570] in Source-Commits
Re: /svn/athena r25091 - trunk/debathena/config/gdm-config/debian
daemon@ATHENA.MIT.EDU (Geoffrey Thomas)
Tue Apr 19 12:58:22 2011
Date: Tue, 19 Apr 2011 12:58:14 -0400 (EDT)
From: Geoffrey Thomas <geofft@MIT.EDU>
To: Jonathan D Reed <jdreed@mit.edu>
cc: source-commits@mit.edu
In-Reply-To: <201104191552.p3JFqoLX008303@drugstore.mit.edu>
Message-ID: <alpine.DEB.2.00.1104191248550.18674@lunatique.mit.edu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
You should do lt-nl instead of lt, since lt considers the empty string to
be version -infinity, and therefore this will trigger a reboot even if the
package has never been installed before.
I'd also prefer if you can find a way to do this in a way that only
affects cluster machines, e.g.,
if [ `machtype -L` = debathena-cluster ] && dpkg --compare-versions "$2" lt-nl '1.26~'; then
--
Geoffrey Thomas
geofft@mit.edu
On Tue, 19 Apr 2011, Jonathan D Reed wrote:
> Author: jdreed
> Date: 2011-04-19 11:52:50 -0400 (Tue, 19 Apr 2011)
> New Revision: 25091
>
> Modified:
> trunk/debathena/config/gdm-config/debian/changelog
> trunk/debathena/config/gdm-config/debian/debathena-gdm-config.postinst
> Log:
> In gdm-config:
> * Force a reboot to fix broken nologin-monitor
>
>
> Modified: trunk/debathena/config/gdm-config/debian/changelog
> ===================================================================
> --- trunk/debathena/config/gdm-config/debian/changelog 2011-04-13 15:01:55 UTC (rev 25090)
> +++ trunk/debathena/config/gdm-config/debian/changelog 2011-04-19 15:52:50 UTC (rev 25091)
> @@ -1,3 +1,9 @@
> +debathena-gdm-config (1.26) unstable; urgency=low
> +
> + * Force a reboot to fix broken nologin-monitor
> +
> + -- Jonathan Reed <jdreed@mit.edu> Tue, 19 Apr 2011 11:52:18 -0400
> +
> debathena-gdm-config (1.25) unstable; urgency=low
>
> * Applets shouldn't attempt to steal focus
>
> Modified: trunk/debathena/config/gdm-config/debian/debathena-gdm-config.postinst
> ===================================================================
> --- trunk/debathena/config/gdm-config/debian/debathena-gdm-config.postinst 2011-04-13 15:01:55 UTC (rev 25090)
> +++ trunk/debathena/config/gdm-config/debian/debathena-gdm-config.postinst 2011-04-19 15:52:50 UTC (rev 25091)
> @@ -68,6 +68,9 @@
>
> case "$1" in
> configure)
> + if dpkg --compare-versions "$2" lt '1.26~'; then
> + touch /var/run/reboot-required
> + fi
> gdm_version="$(dpkg-query -W -f '${Version}' gdm)"
> if dpkg --compare-versions "$gdm_version" ge '2.25.2~'; then
> cleanup_old_diversion /etc/gdm/gdm.conf
>
>
