[766] in Moira
com_err shouldn't print '\r' after '\n' when printing errors
daemon@ATHENA.MIT.EDU (Jonathan I. Kamens)
Fri Sep 2 13:57:10 1994
Date: Fri, 2 Sep 1994 13:58:04 -0400
From: "Jonathan I. Kamens" <jik@cam.ov.com>
To: krb5-bugs@MIT.EDU, bug-zephyr@MIT.EDU, bugs@MIT.EDU, bug-moira@MIT.EDU
Com_err shouldn't be printing '\r' after '\n' when it prints errors in
the com_err_proc function, for two reasons:
1) The terminal driver handles changing '\n' to "\r\n" when it's
necessary.
2) Even if that weren't the case, the '\r' is supposed to come
*before* the '\n', not after, as the current code does it.
The patch below just removes the printing of '\r'.
Jonathan Kamens | OpenVision Technologies, Inc. | jik@cam.ov.com
--- com_err.c 1994/03/23 16:08:31 1.2
+++ com_err.c 1994/09/02 16:14:53
@@ -57,8 +57,6 @@
vfprintf (stderr, fmt, args);
}
putc('\n', stderr);
- /* should do this only on a tty in raw mode */
- putc('\r', stderr);
fflush(stderr);
}
