[5528] in Moira
Re: Two patches
daemon@ATHENA.MIT.EDU (Garry P Zacheiss)
Mon Jan 4 19:46:02 2010
From: Garry P Zacheiss <zacheiss@MIT.EDU>
To: Evan Broder <broder@mit.edu>
CC: "moiradev@mit.edu" <moiradev@mit.edu>
Date: Mon, 4 Jan 2010 19:45:51 -0500
Message-ID: <82185C8E-C8CF-4A73-A1F2-C0A4F21DC270@mit.edu>
In-Reply-To: <178868c41001041605i51496f03pc6f9a555cf1c1c28@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Thanks, looks good. First 2 checked in; still pondering third.
Garry
On Jan 4, 2010, at 7:05 PM, Evan Broder wrote:
> On Mon, Jan 4, 2010 at 4:06 PM, Garry P Zacheiss <zacheiss@mit.edu> wrote:
>>> One thought I had was that, if I was doing Python bindings for
>>> libmoira itself, it would also be really nice if we also had Python
>>> bindings for libmrclient, so that apps using the Python modules
>>> wouldn't need to duplicate code, but Python gets snippy if you try to
>>> build extensions against statically linked libraries. Would you be
>>> amenable to a patch to build libmrclient as a shared library as well
>>> as libmoira?
>>>
>>
>> Nope, that would be fine.
>
> This turned out to be a lot easier than the original shared libmoira
> switchover. shared-libmrclient.diff uses libtool for building
> libmrclient, and for linking it into the clients.
>
> I also have missing-library-function.diff - moira.h doesn't have a
> prototype for mr_krb5_auth.
>
> Finally, I don't want to rush you in your mulling, but if you do
> decide to include the header files, install-headers.diff is a new
> version that also installs mrclient.h.
>
> - Evan
> <shared-libmrclient.diff><missing-library-function.diff><install-headers.diff>
