[5517] in Moira
Re: Two patches
daemon@ATHENA.MIT.EDU (Evan Broder)
Sat Jan 2 19:24:29 2010
MIME-Version: 1.0
In-Reply-To: <178868c41001021533x11666164i1fc8a059779237ef@mail.gmail.com>
Date: Sat, 2 Jan 2010 18:24:19 -0600
Message-ID: <178868c41001021624y1f1a3aaena5a550b8723f375@mail.gmail.com>
From: Evan Broder <broder@MIT.EDU>
To: moiradev@mit.edu
Content-Type: multipart/mixed; boundary=001636c5bd0b2bf597047c37a03d
--001636c5bd0b2bf597047c37a03d
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Hmm...I guess that was actually 3 patches - I forgot to update the subject.
In any case, I do have one more that I just noticed. Because
configure.in adds -L$(BUILDTOP)/lib to the LDFLAGS, that flag makes
its way into the libmoira.la file that libtool generates as a
superfluous reference to the build area (c.f. the /usr/lib/libmoira.la
distributed in debathena-libmoira-dev).
As far as I can tell, the only thing that flag should allow is linking
with -lmoira, but there's already MR_LIBDEP for that, so I'm pretty
sure that linker flag can be dropped.
no-extra-ldflags.diff, attached, does so.
Thanks,
- Evan
On Sat, Jan 2, 2010 at 5:33 PM, Evan Broder <broder@mit.edu> wrote:
> Hi -
> =A0 =A0I've attached two patches I put together as part of my work on
> MacAthena, and one from Debathena
>
> First, ./configure sets a sysconfdir variable, intended for
> system-wide configuration files (i.e. the configurable version of
> /etc). respect-sysconfdir.diff causes the update_server to respect
> sysconfdir when installing and looking for moira.conf.
>
> Second, OS X has a bizarro version of com_err. For whatever reason,
> initialize_FOO_error_table() is a NOOP; unless you call
> add_error_table(&et_FOO_error_table) instead, com_err doesn't have
> access to the error tables and you get numeric error messages. Except
> for libkrb5, where you need to build with -framework Kerberos to get
> access to the error tables (but don't need to call add_error_table).
> Like I said, bizarro.
>
> fix-os-x-comerr.diff updates both the build flags and
> initialize_FOO_error_table calls to do the correct thing. Both patches
> will only have any effect if Moira is being built on OS X. (The patch
> to configure.in is based on r23277 I committed to Debathena a while
> back).
>
> Finally, now Moira can be built as a shared library, but it's not
> possible to build additional out-of-tree clients against it, because
> the headers aren't currently installed. I'm particularly interested in
> seeing the headers installed for my Python bindings to libmoira[1],
> which Debathena is hoping to use in a series of more user-friendly
> graphical Moira clients in the near future. install-headers.diff
> installs <moira/moira.h>, <moira/mr_et.h>, <moira/krb_et.h>, and
> <moira/ureg_err.h>. I put them under the moira/ subdirectory to avoid
> any potential conflicts with krb_et.h, but if you'd prefer to see them
> go directly into $(includedir), that's fine with me as well.
>
> As always, please let me know if you have any comments or concerns, or
> if there's anything I can do to improve these patches.
>
> Thanks,
> =A0- Evan
>
> [1] http://github.com/ebroder/python-moira
>
--001636c5bd0b2bf597047c37a03d
Content-Type: application/octet-stream; name="no-extra-ldflags.diff"
Content-Disposition: attachment; filename="no-extra-ldflags.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_g3z2xioi3
SW5kZXg6IGNvbmZpZ3VyZS5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuaW4JKHJldmlzaW9u
IDM5NDUpCisrKyBjb25maWd1cmUuaW4JKHdvcmtpbmcgY29weSkKQEAgLTQ2MSw3ICs0NjEsNyBA
QAogTVJfSU5DTFVERSgnJChCVUlMRFRPUCkvbGliJykKIE1SX0lOQ0xVREUoJyQoQlVJTERUT1Ap
L2RiJykKIE1SX0lOQ0xVREUoJyQoc3JjZGlyKScpCi1MREZMQUdTPSIkTERGTEFHUyAtTFwkKEJV
SUxEVE9QKS9saWIgJExJQlBBVEgiCitMREZMQUdTPSIkTERGTEFHUyAkTElCUEFUSCIKIEtMSUJT
PSIkS1JCNF9MSUJTICRLUkI1X0xJQlMgLWxjb21fZXJyICRMSUJTIgogS0xJQlM9IiRMSUJTIgog
aWYgdGVzdCAiJGhlc2lvZCIgIT0gbm87IHRoZW4K
--001636c5bd0b2bf597047c37a03d--
