[2010] in Moira
Re: moira shouldn't allow list members which contain a ","
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Thu Apr 24 18:46:01 2003
Message-Id: <200304242245.h3OMjwb3004709@brad-majors.mit.edu>
To: Mark Silis <mark@MIT.EDU>
cc: bug-moira@MIT.EDU, nog@MIT.EDU
In-Reply-To: Your message of "Fri, 18 Apr 2003 09:48:42 EDT."
<77815534-71A4-11D7-A81E-000A959D0696@mit.edu>
Date: Thu, 24 Apr 2003 18:45:58 -0400
From: Garry Zacheiss <zacheiss@MIT.EDU>
>> A recent problem a user was having with a mailing list was tracked down
>> to a bad entry which contained a ",". Moira probably should not allow
>> users to add entries which contain a "," character to a mailing list
>> because it breaks alias expansion on the mailhubs and mail to the list
>> then simply bounces. Although I admit there may be some rational reason
>> its necessary that I have failed to capture.
I can't think of any reason why it would be necessary. The patch
below to add_member_to_list() should be the easy way of accomplishing
it, and is now running on ttsp.
Index: qsupport.pc
===================================================================
RCS file: /afs/athena.mit.edu/astaff/project/moiradev/repository/moira/server/qsupport.pc,v
retrieving revision 2.46
diff -u -r2.46 qsupport.pc
--- qsupport.pc 18 Nov 2002 20:19:33 -0000 2.46
+++ qsupport.pc 24 Apr 2003 22:37:56 -0000
@@ -203,7 +203,7 @@
status = id_to_name(mid, STRINGS_TABLE, &buf);
if (status)
return status;
- if (strchr(buf, '/') || strchr(buf, '|'))
+ if (strchr(buf, '/') || strchr(buf, '|') || strchr(buf, ','))
{
free(buf);
return MR_BAD_CHAR;
