[1956] in Moira
Re: calendar.gen
daemon@ATHENA.MIT.EDU (Marc Horowitz)
Wed May 15 17:44:28 2002
From: Marc Horowitz <marc@MIT.EDU>
To: Garry Zacheiss <zacheiss@MIT.EDU>
Cc: Mark Silis <mark@MIT.EDU>, moiradev@MIT.EDU
Date: 15 May 2002 17:44:26 -0400
In-Reply-To: Garry Zacheiss's message of "Wed, 15 May 2002 17:24:30 -0400"
Message-ID: <t53znz184sl.fsf@horowitz-m1.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Garry Zacheiss <zacheiss@MIT.EDU> writes:
>> >> + if (length($office_phone) == 5) {
>> >> + $office_phone = "617-25" . substr($office_phone, 0, 1) . "-" .
>> >> + substr($office_phone, 1, 4);
>>
>> You need to be more careful here; some people have office phones
>> listed as being in the 225 exchange, and this will do the wrong thing
>> for them. You might consider explicity checking for a leading 2, 3, or
>> 8 in addition to checking that office_phone is length 5.
In addition, you have to deal with x2-abcd numbers which can be
452-abcd or 252-abcde depending on the value of a, and maybe b.
Marc
