[1918] in Moira
Re: mailhub.sh changes
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Fri Jan 18 17:52:05 2002
Message-Id: <200201182252.RAA24749@sweet-transvestite.mit.edu>
To: Mark Silis <mark@MIT.EDU>
cc: moiradev@MIT.EDU, postmaster@MIT.EDU
In-Reply-To: Your message of "Fri, 18 Jan 2002 15:57:33 EST."
<20020118205733.GA391@I-fear-reorgs.MIT.EDU>
Date: Fri, 18 Jan 2002 17:52:03 -0500
From: Garry Zacheiss <zacheiss@MIT.EDU>
>> +# Catch the zero case
>> +if [ $nlines -eq 0 ]; then
>> + logger -p mail.error -t mailhub.sh "Recieved empty aliases file,
>> aborting."
>> + exit $MR_MKCRED
>> +fi
>> +
>> +# If its a greater than 10% shift bomb out to be safe
>> +if [ $diff -gt $thresh ]; then
>> + logger -p mail.error -t mailhub.sh "Alias changes threshold
>> exceeded, aborting."
>> + exit $MR_MKCRED
>> +fi
I'd like to see these exit values replaced with $MR_MISSINGFILE and
$MR_NOCRED, respectively. I think the error string they correspond to
will be a little more descriptive of the problem that $MR_MKCRED is.
Other than that, it looks good.
Garry
