[1755] in Moira
Re: changes to setpw.c
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Mon Mar 19 16:39:43 2001
Message-Id: <200103192139.QAA11960@sweet-transvestite.mit.edu>
To: "David E. Tanner" <dtanner@MIT.EDU>
cc: moiradev@MIT.EDU
In-Reply-To: Your message of "Mon, 19 Mar 2001 16:15:29 EST."
<3.0.32.20010319161528.0119d008@po14.mit.edu>
Date: Mon, 19 Mar 2001 16:39:35 -0500
From: Garry Zacheiss <zacheiss@MIT.EDU>
Ezra's comment is valid; krb5_free_data_contents should be valid
on all platforms; there's no reason to only use it under win32. One
other small comment is that this indentation:
! if (local_result_code)
! {
! if (local_result_code == KRB5_KPASSWD_SOFTERROR)
! local_result_code = KRB5_KPASSWD_SUCCESS;
! *result_code = local_result_code;
! }
is horrible. Please reformat is so that it's indented the same way as
all the other if statements in the module.
Garry
