[1717] in Moira
duplicate labels on some po boxes and an inconsistancy
daemon@ATHENA.MIT.EDU (zacheiss@MIT.EDU)
Mon Dec 25 00:13:38 2000
Message-Id: <200012250513.AAA01393@bluebox-295.mit.edu>
To: moira-admin@MIT.EDU, moiradev@MIT.EDU
From: zacheiss@MIT.EDU
Date: Mon, 25 Dec 2000 00:13:31 -0500
There are currently 22 filesystems in moira that have duplicate
labels; all are users that have potypes of 'SPLIT' or 'SMTP' and were
status 6 users that were recently registered up to status 1 by accounts.
The imap_id on all of their accounts points to the newer filesystem, so it
should be safe to delete the old filesystem. It is my intent to do this
when I do the purge of the class of '99. The filesystem labels affected are:
bernardi.po
cromero.po
dlations.po
dsilverm.po
dunbar.po
janb.po
jcollins.po
jcombs.po
jmen.po
jnarcott.po
lverma.po
ori.po
phealy.po
prior.po
rcatella.po
rizzo.po
sclute.po
smythe.po
tushmanm.po
vclark.po
vcrayton.po
wpwohlfa.po
Enclosed below is a moirad patch to prevent the problem in the
future; the currently existing code failed to deal with the case of a
status 6 user with an existing IMAP pobox that was chpoboxed away from
it.
Additionally, I noticed that the code currently in the moira
source tree will create the filesystems for IMAP po's with a
mountpoint of CHR(0) (C style null character), but tom created all the
poboxes for the people moved manually with a mountpoint of 'NONE'.
Nothing actually looks at this value, so it really doesn't matter what
we use. It would be more convenient to standardize on CHR(0) instead
of 'NONE', but I can go either way. Someone who feels strongly should let
me know what they'd like to happen.
Garry
Index: qsupport.pc
===================================================================
RCS file: /afs/athena.mit.edu/astaff/project/moiradev/repository//moira/server/qsupport.pc,v
retrieving revision 2.29
diff -u -r2.29 qsupport.pc
--- qsupport.pc 2000/09/27 03:33:16 2.29
+++ qsupport.pc 2000/12/25 05:00:30
@@ -1478,11 +1478,7 @@
return mr_errcode;
if ((ostatus == 0) || (tmp != users_id))
return MR_IN_USE;
- EXEC SQL SELECT count(potype) INTO :rowcount FROM users WHERE
- login = :login AND potype = 'IMAP';
- if (dbms_errno)
- return mr_errcode;
- if (rowcount > 0)
+ else
po_exists = 1;
}
EXEC SQL SELECT COUNT(name) INTO :rowcount FROM alias
