[1684] in Moira
cryptic, yet strangely satisfying
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Tue Oct 17 13:48:58 2000
Message-Id: <200010171748.NAA01671@riff-raff.mit.edu>
To: moiradev@MIT.EDU
Date: Tue, 17 Oct 2000 13:48:54 -0400
From: Garry Zacheiss <zacheiss@MIT.EDU>
It is currently the case that if one passes an empty string as
the ace_name to alis or ulis when ace_type == "LIST" , the owner will
get to the next list_id pulled out of the numvals table; that is to say,
the list will end up owned by the next list to be created.
This can be traced to the fact that strings are not pointers to
integers. Here's a patch.
It's even, like, tested and stuff.
Garry
Index: qvalidate.pc
===================================================================
RCS file: /afs/athena.mit.edu/astaff/project/moiradev/repository/moira/server/qvalidate.pc,v
retrieving revision 2.19
diff -c -r2.19 qvalidate.pc
*** qvalidate.pc 1999/08/06 18:46:15 2.19
--- qvalidate.pc 2000/10/17 17:35:30
***************
*** 375,381 ****
* that we're trying to resolve, we should get the value of
* numvalues.[idfield] for the id.
*/
! if (vo->idfield && !strcmp(argv[0], argv[vo->index]))
{
set_next_object_id(q->validate->object_id, q->rtable, 0);
name = vo->idfield;
--- 375,381 ----
* that we're trying to resolve, we should get the value of
* numvalues.[idfield] for the id.
*/
! if (vo->idfield && (*(int *)argv[0] == *(int *)argv[vo->index]))
{
set_next_object_id(q->validate->object_id, q->rtable, 0);
name = vo->idfield;
