[1566] in Moira

home help back first fref pref prev next nref lref last post

Re: access_list() fixes

daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Fri Jun 2 13:28:55 2000

Message-Id: <200006021728.NAA23633@speaker-for-the-dead.mit.edu>
From: Jonathon Weiss <jweiss@MIT.EDU>
To: Garry Zacheiss <zacheiss@MIT.EDU>
cc: moiradev@MIT.EDU
In-reply-to: Your message of "Fri, 02 Jun 2000 05:29:37 EDT."
             <200006020929.FAA14289@shock-treatment.mit.edu> 
Date: Fri, 02 Jun 2000 13:28:47 -0400

> >> Shouldn't that be strlen(newname)>5  ?  (including the hyphen)
> 
>    Well, it depends on whether we want to stop someone from taking the
> list name "sp00-".  I don't think it really matters one way or the
> other.  It can be 5 if that gives you warm fuzzies.

I was nervous about tryign to compare the 5 character of a 4 character
list, but I guess the null termination would save us there.

>    The client will print "Unknown error code 71" or whatever like any
> com_err application would.  This shouldn't stop us from adding new error
> codes, since the logical conclusion is that we should never add another
> error code again.  People with local moira clients earn no pity if
> they're not clueful enough to cope.

I wanted to make sure the failure was at least that graceful before
deeming it reasonable.  It's a little annoying, but I agree that it's
not a reason not to add the new error code.

	Jonathon


home help back first fref pref prev next nref lref last post