[1543] in Moira
Re: gen script changes
daemon@ATHENA.MIT.EDU (Jonathon Weiss)
Sat May 6 22:29:06 2000
Message-Id: <200005070229.WAA17482@Bearing-An-Hourglass.mit.edu>
From: Jonathon Weiss <jweiss@MIT.EDU>
To: Garry Zacheiss <zacheiss@MIT.EDU>
cc: moiradev@MIT.EDU
In-reply-to: Your message of "Wed, 03 May 2000 20:32:20 EDT."
<200005040032.UAA02053@RIFF-RAFF-W20.MIT.EDU>
Date: Sat, 06 May 2000 22:29:01 -0400
> Pretty self explanatory. Also includes a rewrite of nfs.sh to
> be in the Bourne shell.
The changes you suggest to log the output of the DCM scripts has teh
problem that on hosts that get more than one DCM (eg, moira) only the
output from the last DCM would be saved. Would it be better to log
things to /var/athena/moira_<dcmname>_update.log? Logging things to
/tmp is also vulnerable to a symlink attack
> --- 1,102 ----
> ! #!/bin/sh
> # This script performs nfs updates on servers.
> ! SRCDIR=/var/tmp/nfs.dir
Sould we move this to /var/athena too?
> ! echo $uchost | egrep -e "." >/dev/null
You need to quote the . from egrep, since . matches any character.
You may also want to supress the output of the grep since you don't
want to see the hostname, just make sure it is an FQDN.
> ! # Make a temporary directory to unpack the tar file into
> ! mkdir $SRCDIR || exit $MR_MKCRED
The old script rm'd this directory if it existed, you probably still
want to do that.
> ! mv -f $i /var/tmp
/var/athena (yeah, I know the old script used /var/tmp.)
Jonathon
