[1530] in Moira
Re: proposed changes for adding a new field to User table
daemon@ATHENA.MIT.EDU (Garry Zacheiss)
Sat Apr 15 17:06:25 2000
Message-Id: <200004152106.RAA01362@riff-raff-w20.mit.edu>
To: Qing Dong <dongq@MIT.EDU>
Cc: Garry Zacheiss <zacheiss@MIT.EDU>, moiradev@MIT.EDU, pbh@MIT.EDU,
dalmeida@MIT.EDU
In-Reply-To: Your message of "Thu, 13 Apr 2000 17:43:17 EDT."
<200004132143.RAA29805@melbourne-city-street.MIT.EDU>
Date: Sat, 15 Apr 2000 17:06:22 -0400
From: Garry Zacheiss <zacheiss@MIT.EDU>
Based on Danilo's mail, I've decided that sticking with
"winconsoleshell" for all the variables and the schema is fine (not that
you changed that).
More comments:
>> + fprintf(stderr, " -w | -winshell windows console shell (default
>> %s)\n", DEFAULT_WINCONSOLESHELL);
I prefer this wrapped into two lines.
>> +
>> + if (GetValueFromUser("Windows console shell", &info[U_WINCONSOLESHELL])
>> == SUB_ERROR)
>> + return NULL;
>> +
Same here.
>> ! sprintf(fullname, "%s %s %s", argv[U_FIRST], argv[U_MIDDLE],
>> argv[U_LAST]);
Again here.
>> + {V_CHAR, 4, USERS_TABLE, "winconsoleshell",
You're missing a close brace here, in uuac_valobj.
These are all little things, though, so you don't need to resubmit
your changes with these corrected. Everything else looks reasonable.
For the next step, I'd like to add the column to ttsp's database and
test the new server and clients for a while before committing any of
this. I believe I asked this earlier, but is a deploy time of late May
acceptable for this work?
Garry
